Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(284)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
6478045
: Fixed instance counting for templated classes (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by
robertphillips
Modified:
12 years ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
More Reviews
Description
This CL get instance counting working for the SkMaskGamma class.
Patch Set 1
#
Created:
12 years ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+15 lines, -2 lines
)
Patch
M
include/core/SkInstCnt.h
View
1 chunk
+8 lines, -0 lines
0 comments
Download
M
src/core/SkMaskGamma.h
View
2 chunks
+7 lines, -1 line
0 comments
Download
M
src/core/SkScalerContext.cpp
View
1 chunk
+0 lines, -1 line
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
robertphillips
12 years ago (2012-08-22 15:03:58 UTC)
#1
Sign in
to reply to this message.
bsalomon
LGTM
12 years ago (2012-08-22 15:10:21 UTC)
#2
LGTM
Sign in
to reply to this message.
robertphillips
committed as r5233
12 years ago (2012-08-22 17:31:45 UTC)
#3
committed as r5233
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 6478045: Fixed instance counting for templated classes (Closed)
Created 12 years ago by robertphillips
Modified 12 years ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b