Run fixcc + astyle2.02.1

Run fixcc + astyle2.02.1

[Graham Percival, 2012-08-27 09:45:59]

This shows the difference between astyle 2.02 and 2.02.1.  The only change is
  <something>* foo
into
  <something> *foo

which looks good to me because the rest of the source code sticks the * next to
the variable name, rather than the variable type.

If I can get two LGTMs, I'll push this directly to staging so that other people
(notably Mike) can run astyle with 2.02.1.

[John Mandereau, 2012-08-27 10:04:21]

LGTM

(to enlighten the potential bias that made me say LGTM, as I looked at all
changes in the patch but I'm not fluent at all in C++, I also have astyle 2.02.1
on Fedora 17 :-p)

[benko.pal, 2012-08-27 10:10:52]

LGTM

[benko.pal, 2012-08-27 10:21:53]

http://codereview.appspot.com/6477062/diff/1/lily/include/skyline.hh
File lily/include/skyline.hh (right):

http://codereview.appspot.com/6477062/diff/1/lily/include/skyline.hh#newcode58
lily/include/skyline.hh:58: list<Building> *const result);
I'd like to see the const removed (top-level const on function parameter types
are ignored), but that may be the target of another patch.

[Graham Percival, 2012-08-27 17:37:00]

On Mon, Aug 27, 2012 at 10:21:53AM +0000, benko.pal@gmail.com wrote:
> 
> lily/include/skyline.hh:58: list<Building> *const result);
> I'd like to see the const removed (top-level const on function parameter
> types are ignored), but that may be the target of another patch.

Good idea!  However, that would be a more intelligent
modification, which doesn't fit with fixcc's mandate.  At the
moment I just want to move forward with the automatic formatting.

- Graham