Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(644)

Issue 6476064: Added second "truncated" cpu/wall timer to bench (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by robertphillips
Modified:
11 years, 10 months ago
Reviewers:
bungeman, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The old bench timings weren't including the time for the OpenGL commands to finish. This CL adds that time to the standard wall, cpu and gpu times and adds a new truncated timer that does not include that time in its wall and cpu times.

Patch Set 1 #

Patch Set 2 : removed old comment #

Total comments: 4

Patch Set 3 : Altered truncated timer flags & output strings #

Total comments: 2

Patch Set 4 : Updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -15 lines) Patch
M bench/BenchTimer.h View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M bench/BenchTimer.cpp View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
M bench/benchmain.cpp View 1 2 10 chunks +50 lines, -8 lines 0 comments Download
M tools/PictureBenchmark.cpp View 1 2 10 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6
robertphillips
11 years, 10 months ago (2012-08-24 20:08:47 UTC) #1
bungeman
http://codereview.appspot.com/6476064/diff/2001/bench/benchmain.cpp File bench/benchmain.cpp (right): http://codereview.appspot.com/6476064/diff/2001/bench/benchmain.cpp#newcode399 bench/benchmain.cpp:399: "[-timers [wcg23]*] [-rotate]\n" wcgWC http://codereview.appspot.com/6476064/diff/2001/bench/benchmain.cpp#newcode868 bench/benchmain.cpp:868: SkString fTruncatedWallStr(" msecs ...
11 years, 10 months ago (2012-08-24 20:28:51 UTC) #2
robertphillips
http://codereview.appspot.com/6476064/diff/2001/bench/benchmain.cpp File bench/benchmain.cpp (right): http://codereview.appspot.com/6476064/diff/2001/bench/benchmain.cpp#newcode399 bench/benchmain.cpp:399: "[-timers [wcg23]*] [-rotate]\n" On 2012/08/24 20:28:51, bungeman wrote: > ...
11 years, 10 months ago (2012-08-27 13:08:46 UTC) #3
bsalomon
LGTM https://codereview.appspot.com/6476064/diff/1006/bench/BenchTimer.h File bench/BenchTimer.h (left): https://codereview.appspot.com/6476064/diff/1006/bench/BenchTimer.h#oldcode21 bench/BenchTimer.h:21: * This class combines a SysTimer and a ...
11 years, 10 months ago (2012-08-27 13:31:14 UTC) #4
robertphillips
https://codereview.appspot.com/6476064/diff/1006/bench/BenchTimer.h File bench/BenchTimer.h (left): https://codereview.appspot.com/6476064/diff/1006/bench/BenchTimer.h#oldcode21 bench/BenchTimer.h:21: * This class combines a SysTimer and a GpuTimer ...
11 years, 10 months ago (2012-08-27 15:35:35 UTC) #5
robertphillips
11 years, 10 months ago (2012-08-28 12:19:00 UTC) #6
committed as r5305
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b