Issue 6476051: Issue 2745: more fun with accidental rules.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6476051: Issue 2745: more fun with accidental rules. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dak

Modified:
11 years, 7 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issue 2745: more fun with accidental rules. There was still code mixing up the somewhat orthogonal concept of single-octave accidentals with non-keysignature accidentals. Also a bug in teaching accidental rules which never saw accidentals in the key signature.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Revert bad teaching accidental change, but eliminate call always evaluating to #f #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	scm/music-functions.scm	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

11 years, 8 months ago (2012-09-03 19:02:11 UTC) #1

Looks good to me if I change just one letter.

http://codereview.appspot.com/6476051/diff/1/scm/music-functions.scm
File scm/music-functions.scm (right):

http://codereview.appspot.com/6476051/diff/1/scm/music-functions.scm#newcode1409
scm/music-functions.scm:1409: (let* ((global-entry (find-pitch-entry keysig
pitch #t #f))
This is the function that identifies cautionary accidentals, so it was actually
/intended/ to completely ignore the key signature, thus requesting reminder
cautionaries for pitches in the key.

Expand All Messages | Collapse All Messages