Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5230)

Issue 6475061: code review 6475061: cmd/gc: fix escape analysis bug with variable capture i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by remyoudompheng
Modified:
11 years, 7 months ago
Reviewers:
CC:
rsc, lvd1, golang-dev, remy_archlinux.org
Visibility:
Public.

Description

cmd/gc: fix escape analysis bug with variable capture in loops. Fixes issue 3975.

Patch Set 1 #

Patch Set 2 : diff -r 93b44db58f94 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 93b44db58f94 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 9e610a78455c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r d15f71f90167 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M src/cmd/gc/esc.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/escape.go View 1 2 3 3 chunks +21 lines, -6 lines 0 comments Download
M test/escape2.go View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2012-08-25 07:26:12 UTC) #1
nigeltao
https://codereview.appspot.com/6475061/diff/3004/test/escape.go File test/escape.go (right): https://codereview.appspot.com/6475061/diff/3004/test/escape.go#newcode149 test/escape.go:149: *p = i Run gofmt.
11 years, 7 months ago (2012-08-27 01:49:11 UTC) #2
remyoudompheng
Hello rsc@golang.org, lvd@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
11 years, 7 months ago (2012-08-27 05:49:48 UTC) #3
rsc
LGTM
11 years, 7 months ago (2012-08-31 20:08:04 UTC) #4
remyoudompheng
11 years, 7 months ago (2012-08-31 20:23:58 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=238a5fd52836 ***

cmd/gc: fix escape analysis bug with variable capture in loops.

Fixes issue 3975.

R=rsc, lvd
CC=golang-dev, remy
http://codereview.appspot.com/6475061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b