Issue 6465054: code review 6465054: runtime: fix netbsd/386 stack pointer handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6465054: code review 6465054: runtime: fix netbsd/386 stack pointer handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by jsing

Modified:
11 years, 8 months ago

Reviewers:

CC:
golang-dev, minux1, r, bsiegert

Visibility:
Public.

Description

runtime: fix netbsd/386 stack pointer handling When manipulating the stack pointer use the UESP register instead of the ESP register, since the UESP register is the one that gets restored from the machine context. Fixes broken tests on netbsd/386.

Patch Set 1 #

Patch Set 2 : diff -r f72ea96fab80 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f72ea96fab80 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 53116ca07207 https://go.googlecode.com/hg/ #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/pkg/runtime/signal_netbsd_386.c	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2012-08-15 18:21:25 UTC) #1

minux1

LGTM. (I've read the relevant source code at http://fxr.watson.org/fxr/source/arch/i386/i386/machdep.c?v=NETBSD ) just curious, why NetBSD do ...

11 years, 8 months ago (2012-08-16 19:23:42 UTC) #2

jsing

11 years, 8 months ago (2012-08-17 11:52:51 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c568561320a3 ***

runtime: fix netbsd/386 stack pointer handling

When manipulating the stack pointer use the UESP register instead
of the ESP register, since the UESP register is the one that gets
restored from the machine context. Fixes broken tests on netbsd/386.

R=golang-dev, minux.ma, r, bsiegert
CC=golang-dev
http://codereview.appspot.com/6465054

Expand All Messages | Collapse All Messages