Clean up most clang warnings outside animator/

[TomH, 2012-08-14 13:46:24]

http://codereview.appspot.com/6464058/diff/1/src/utils/SkDumpCanvas.cpp
File src/utils/SkDumpCanvas.cpp (right):

http://codereview.appspot.com/6464058/diff/1/src/utils/SkDumpCanvas.cpp#newco...
src/utils/SkDumpCanvas.cpp:140: str->printf("\"%.*ls\"%s", SkMax32(len, 32),
(const wchar_t*) text,
I think there's actually a latent bug here - should these be SkMax32(len, 64),
and 128 below?

[robertphillips, 2012-08-14 14:12:21]

LGTM

http://codereview.appspot.com/6464058/diff/1/src/utils/SkDumpCanvas.cpp
File src/utils/SkDumpCanvas.cpp (right):

http://codereview.appspot.com/6464058/diff/1/src/utils/SkDumpCanvas.cpp#newco...
src/utils/SkDumpCanvas.cpp:140: str->printf("\"%.*ls\"%s", SkMax32(len, 32),
(const wchar_t*) text,
I think the 64 & 128 should be switched to 32s.

[reed1, 2012-08-14 14:44:16]

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp
File bench/benchmain.cpp (right):

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp#newcode244
bench/benchmain.cpp:244: GrContext* grCtx;
Perhaps we should move rt inside the if...

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp#newcode265
bench/benchmain.cpp:265: }
If we move these 5 lines inside the 'if' then we can move rt's declaration there
as well

http://codereview.appspot.com/6464058/diff/2001/tests/MathTest.cpp
File tests/MathTest.cpp (right):

http://codereview.appspot.com/6464058/diff/2001/tests/MathTest.cpp#newcode201
tests/MathTest.cpp:201: SkString desc;
#include "SkFloatBits.h"

int32_t xi = SkFloat2Bits(x);

[TomH, 2012-08-14 15:03:56]

Closed with r5079.

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp
File bench/benchmain.cpp (right):

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp#newcode244
bench/benchmain.cpp:244: GrContext* grCtx;
On 2012/08/14 14:44:16, reed1 wrote:
> Perhaps we should move rt inside the if...

Done.

http://codereview.appspot.com/6464058/diff/2001/bench/benchmain.cpp#newcode265
bench/benchmain.cpp:265: }
On 2012/08/14 14:44:16, reed1 wrote:
> If we move these 5 lines inside the 'if' then we can move rt's declaration
there
> as well

Done.

http://codereview.appspot.com/6464058/diff/2001/tests/MathTest.cpp
File tests/MathTest.cpp (right):

http://codereview.appspot.com/6464058/diff/2001/tests/MathTest.cpp#newcode201
tests/MathTest.cpp:201: SkString desc;
On 2012/08/14 14:44:16, reed1 wrote:
> #include "SkFloatBits.h"
> 
> int32_t xi = SkFloat2Bits(x);

Done.

[reed1, 2012-08-14 15:11:44]

http://codereview.appspot.com/6464058/diff/10003/bench/benchmain.cpp
File bench/benchmain.cpp (right):

http://codereview.appspot.com/6464058/diff/10003/bench/benchmain.cpp#newcode243
bench/benchmain.cpp:243: bool init(SkGLContext* glCtx, int width, int height) {
We could move the declaration of grCtx down to line #250...
just saying