Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4652)

Issue 6462073: Make SkDeque::back faster & inline (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by robertphillips
Modified:
12 years, 3 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Maybe a tiny bit faster on our benchmarks: aaclip_build_path_AA 8888 7.41 7.63 -0.22 -3.0% dash_1_noclip 8888 9.44 9.70 -0.26 -2.8% dash_4_noclip 8888 3.55 3.52 +0.03 +0.8% aaclip_setregion 8888 7.19 7.07 +0.12 +1.7% nested_aaclip_AA 8888 3.18 3.01 +0.17 +5.3% aaclip_path_AA 8888 3.92 3.71 +0.21 +5.4% aaclip_rect_AA 8888 2.05 1.93 +0.12 +5.9% dash_0_noclip 8888 1.69 1.59 +0.10 +5.9% nested_aaclip_BW 8888 2.00 1.88 +0.12 +6.0% aaclip_build_path_BW 8888 3.85 3.58 +0.27 +7.0% aaclip_path_BW 8888 2.26 2.08 +0.18 +8.0% aaclip_build_rect_AA 8888 1.11 0.99 +0.12 +10.8% aaclip_build_rect_BW 8888 0.79 0.70 +0.09 +11.4% aaclip_rect_BW 8888 0.73 0.64 +0.09 +12.3% dash_1_clipped 8888 0.31 0.22 +0.09 +29.0%

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -70 lines) Patch
M include/core/SkDeque.h View 4 chunks +22 lines, -4 lines 0 comments Download
M src/core/SkClipStack.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkDeque.cpp View 8 chunks +67 lines, -62 lines 0 comments Download

Messages

Total messages: 4
robertphillips
12 years, 3 months ago (2012-08-17 13:28:00 UTC) #1
reed1
fast, but slightly deep change. Do we feel secure with our current unittests? lgtm
12 years, 3 months ago (2012-08-17 13:48:42 UTC) #2
robertphillips
I feel secure. I actually implemented this in two phases where in the first I ...
12 years, 3 months ago (2012-08-17 13:56:01 UTC) #3
robertphillips
12 years, 3 months ago (2012-08-17 13:56:25 UTC) #4
committed as r5149
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b