Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2532)

Issue 6462069: Batch everything (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by bsalomon
Modified:
12 years, 4 months ago
Reviewers:
reed1, robertphillips, TomH
CC:
rileya, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is dependent upon http://codereview.appspot.com/6460095/ landing first.

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : separate out iodb change into another CL #

Patch Set 4 : remove incorrect param name #

Patch Set 5 : Add comment #

Total comments: 2

Patch Set 6 : Add user config flag to disable batching #

Patch Set 7 : include perf results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -60 lines) Patch
M include/gpu/GrConfig.h View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrUserConfig.h View 1 2 3 4 5 6 2 chunks +8 lines, -2 lines 0 comments Download
A perfchange.txt View 1 2 3 4 5 6 1 chunk +416 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 6 13 chunks +23 lines, -52 lines 0 comments Download

Messages

Total messages: 7
bsalomon
Batch all GrContext draws into IODB. Two motivations: 1) Watch perf bots, see what happens. ...
12 years, 4 months ago (2012-08-16 15:47:35 UTC) #1
bsalomon
I should also add that this caused a couple images to change by an LSB. ...
12 years, 4 months ago (2012-08-16 15:54:44 UTC) #2
TomH
LGTM. Do you have perf #s from your desktop?
12 years, 4 months ago (2012-08-16 15:57:31 UTC) #3
reed1
http://codereview.appspot.com/6462069/diff/7001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): http://codereview.appspot.com/6462069/diff/7001/src/gpu/GrContext.cpp#newcode35 src/gpu/GrContext.cpp:35: // debugging easier. Export this "default" to the outside ...
12 years, 4 months ago (2012-08-16 16:02:18 UTC) #4
bsalomon
Generating local Linux bench runs now... http://codereview.appspot.com/6462069/diff/7001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): http://codereview.appspot.com/6462069/diff/7001/src/gpu/GrContext.cpp#newcode35 src/gpu/GrContext.cpp:35: // debugging easier. ...
12 years, 4 months ago (2012-08-16 16:21:32 UTC) #5
robertphillips
lgtm
12 years, 4 months ago (2012-08-16 18:16:20 UTC) #6
bsalomon
12 years, 4 months ago (2012-08-16 18:38:36 UTC) #7
Committed as r5136.

I uploaded another patchset that includes the output of bench_compare.py on my
linux box. Some of the numbers are to be believed and others are not. The hope
is cpu time goes up a little bit but gpu time goes down more.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b