Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(687)

Issue 6462062: Addressed Windows compiler complaints (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL will require rebaselining of the imagemagnifier GM due to 3-4 different pixels.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M gm/typeface.cpp View 1 chunk +1 line, -1 line 1 comment Download
M src/core/SkPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +31 lines, -26 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +4 lines, -3 lines 2 comments Download
M tools/PictureRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
robertphillips
http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp File gm/typeface.cpp (left): http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp#oldcode37 gm/typeface.cpp:37: } Allocated above @ line 28
12 years, 4 months ago (2012-08-15 14:24:53 UTC) #1
TomH
LGTM. Sad about the constructor signature change, though. http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); ...
12 years, 4 months ago (2012-08-15 14:30:19 UTC) #2
robertphillips
http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); Yep - our usage is safe (since we're ...
12 years, 4 months ago (2012-08-15 14:32:54 UTC) #3
robertphillips
12 years, 4 months ago (2012-08-15 14:37:02 UTC) #4
committed as r5108
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b