http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp File gm/typeface.cpp (left): http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp#oldcode37 gm/typeface.cpp:37: } Allocated above @ line 28
LGTM. Sad about the constructor signature change, though. http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); Why was this generating warnings? Can't pass this before all its fields are initialized?
http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); Yep - our usage is safe (since we're just caching the pointer) but it makes the compiler worry.
committed as r5108