Issue 6462062: Addressed Windows compiler complaints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6462062: Addressed Windows compiler complaints (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL will require rebaselining of the imagemagnifier GM due to 3-4 different pixels.

Patch Set 1 #

Total comments: 3

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -35 lines)			Patch
M	gm/typeface.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/core/SkPath.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkMagnifierImageFilter.cpp	View	3 chunks	+31 lines, -26 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	2 chunks	+4 lines, -3 lines	2 comments	Download
M	tools/PictureRenderer.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp File gm/typeface.cpp (left): http://codereview.appspot.com/6462062/diff/1/gm/typeface.cpp#oldcode37 gm/typeface.cpp:37: } Allocated above @ line 28

11 years, 11 months ago (2012-08-15 14:24:53 UTC) #1

TomH

LGTM. Sad about the constructor signature change, though. http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); ...

11 years, 11 months ago (2012-08-15 14:30:19 UTC) #2

robertphillips

http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp File src/gpu/GrGpu.cpp (right): http://codereview.appspot.com/6462062/diff/1/src/gpu/GrGpu.cpp#newcode43 src/gpu/GrGpu.cpp:43: fClipMaskManager.setGpu(this); Yep - our usage is safe (since we're ...

11 years, 11 months ago (2012-08-15 14:32:54 UTC) #3

committed as r5108

Expand All Messages | Collapse All Messages