remove _UPM_ GrPixelConfigs

[bsalomon, 2012-08-20 18:24:47]

While writing this I discovered that the introduction of GrSingleTextureEffect
caused the premul code in the shader to never get inserted. Thus, we are always
falling back to SW conversion because our canPreserveReadWriteUnpremulPixels()
test fails. This change doesn't address that issue. It will be fixed as part of
the change that moves the premul/unpremul conversion code generation to a custom
stage.

This moves somewhat in the wrong direction (adding state to GrDrawState and
GrSamplerState) but this change makes it cleaner to capture the conversions in a
GrCustomStage, at which point the new state will be removed.

[robertphillips, 2012-08-20 19:09:01]

LGTM + 1 nit + 2 questions

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrRenderTarget.h
File include/gpu/GrRenderTarget.h (left):

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrRenderTarget.h#...
include/gpu/GrRenderTarget.h:55: 
Why remove the comments?

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrSamplerState.h
File include/gpu/GrSamplerState.h (right):

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrSamplerState.h#...
include/gpu/GrSamplerState.h:152: **/
plty->ply

http://codereview.appspot.com/6460113/diff/3021/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6460113/diff/3021/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:352: if (SkBitmap::kARGB_8888_Config == bitmap.config())
{
Where is jconfig defined?

[bsalomon, 2012-08-20 19:21:37]

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrRenderTarget.h
File include/gpu/GrRenderTarget.h (left):

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrRenderTarget.h#...
include/gpu/GrRenderTarget.h:55: 
On 2012/08/20 19:09:01, robertphillips wrote:
> Why remove the comments?

We had essentially 4 versions of this comment (GrContext, GrSurface,
GrRenderTarget, GrTexture). It seemed too fragile/burdensome to keep them in
sync. And we generally don't redocument a subclass's declaration of a overridden
virtual that is documented in the parent class.

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrSamplerState.h
File include/gpu/GrSamplerState.h (right):

http://codereview.appspot.com/6460113/diff/3021/include/gpu/GrSamplerState.h#...
include/gpu/GrSamplerState.h:152: **/
On 2012/08/20 19:09:01, robertphillips wrote:
> plty->ply

Done.

http://codereview.appspot.com/6460113/diff/3021/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6460113/diff/3021/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:352: if (SkBitmap::kARGB_8888_Config == bitmap.config())
{
On 2012/08/20 19:09:01, robertphillips wrote:
> Where is jconfig defined?
Typo, should be config. There was a config = config = ... in the original upload
(that I did my testing with) , when I deleted the first config = I hit 'j'.

[bsalomon, 2012-08-20 19:25:01]

Closed with r5196.