Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2444)

Issue 6460089: Replaced TextureCacheEntry with GrTexture* and a back pointer to GrResourceEntry (in GrTexture) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is a (somewhat) mechanical replacement of TextureCacheEntry with GrTexture* (which now has a back pointer to the GrResourceEntry). Later CLs will make use of the new back pointer to automate the unlocking of textures (among other things).

Patch Set 1 #

Patch Set 2 : Fixed memory leak in GrStencilBuffer.cpp #

Total comments: 5

Patch Set 3 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -219 lines) Patch
M include/gpu/GrContext.h View 1 2 9 chunks +38 lines, -52 lines 0 comments Download
M include/gpu/GrResource.h View 4 chunks +9 lines, -3 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/gpu/SkGr.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 14 chunks +49 lines, -57 lines 0 comments Download
M src/gpu/GrResource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrResourceCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 4 chunks +22 lines, -14 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrStencilBuffer.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 8 chunks +27 lines, -27 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 4 chunks +33 lines, -32 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 4 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 4 months ago (2012-08-15 12:58:30 UTC) #1
bsalomon
Overall LGTM, minor comments below. http://codereview.appspot.com/6460089/diff/1001/include/gpu/GrContext.h File include/gpu/GrContext.h (right): http://codereview.appspot.com/6460089/diff/1001/include/gpu/GrContext.h#newcode182 include/gpu/GrContext.h:182: * Free any data ...
12 years, 4 months ago (2012-08-16 13:42:15 UTC) #2
robertphillips
12 years, 4 months ago (2012-08-16 14:49:52 UTC) #3
committed as r5122

http://codereview.appspot.com/6460089/diff/1001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

http://codereview.appspot.com/6460089/diff/1001/include/gpu/GrContext.h#newco...
include/gpu/GrContext.h:182: * Free any data associated with the provided entry
in the texture cache
On 2012/08/16 13:42:15, bsalomon wrote:
> Could we beef up this comment a little bit. It's not obvious to me what this
> really does (does it remove the texture from the cache and no longer count it
> against the budget?)

Done.

http://codereview.appspot.com/6460089/diff/1001/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

http://codereview.appspot.com/6460089/diff/1001/include/gpu/SkGr.h#newcode82
include/gpu/SkGr.h:82: void GrUnlockCachedBitmapTexture(GrContext*, GrTexture*);
On 2012/08/16 13:42:15, bsalomon wrote:
> Can we get rid of the GrContext param? The texture has a back ptr.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b