Issue 6460061: open url on launch of web server

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6460061: open url on launch of web server (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by mzero

Modified:
13 years, 1 month ago

Reviewers:
Jasvir, Jasvir Nagra, thecomfyshell

Visibility:
Public.

More Reviews

Description

open url on launch of web server simple implementation of this feature: just call xdg-open (or if that fails, open) after sleep 1 second when we run the web server. see issue #3 for related features this CL is _not_ trying to solve: http://code.google.com/p/plush/issues/detail?id=3 commit: http://code.google.com/p/plush/source/detail?r=1e0001d4242196edb177d8257f3af7b7a9c6495c

Patch Set 1 #

Total comments: 1

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/Plush/Server.hs	View		3 chunks	+10 lines, -2 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jasvir

13 years, 1 month ago (2012-08-08 22:15:38 UTC) #2

LGTM

http://codereview.appspot.com/6460061/diff/1/src/Plush/Server.hs
File src/Plush/Server.hs (right):

http://codereview.appspot.com/6460061/diff/1/src/Plush/Server.hs#newcode62
src/Plush/Server.hs:62: openCmd url = "xdg-open " ++ url ++ " 2>/dev/null ||
open " ++ url
clever.

Expand All Messages | Collapse All Messages