a "comment" comment http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode149 MoinMoin/forms.py:149: # optional=True is needed to get ...
12 years, 4 months ago
(2012-08-13 05:16:03 UTC)
#1
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode16 MoinMoin/forms.py:16: from flatland import List from flatland import (Element, ...
12 years, 4 months ago
(2012-08-13 06:41:32 UTC)
#2
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode16 MoinMoin/forms.py:16: from flatland import List On 2012/08/13 06:41:33, ThomasJWaldmann wrote: ...
12 years, 4 months ago
(2012-08-13 07:49:22 UTC)
#3
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode16
MoinMoin/forms.py:16: from flatland import List
On 2012/08/13 06:41:33, ThomasJWaldmann wrote:
> from flatland import (Element, ...
> List)
it was like that to avoid merge conflicts...
what's the policy for import formatting in moin2? since we don't enforce the
78-char limit, the paren isn't a must.
i've moved DateTime as _DateTime to the end though, it looks a bit ugly in the
middle.
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode149
MoinMoin/forms.py:149: # optional=True is needed to get rid of the "required"
flag (usually an asterisk)
On 2012/08/13 05:16:03, Reimar Bauer wrote:
> hmm, that is what optional=True means
> may be add a sentence why those two have that attribute
> or skip it
so... s/flag/flag on the UI/
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode16 MoinMoin/forms.py:16: from flatland import List > it was like that ...
12 years, 4 months ago
(2012-08-13 08:16:36 UTC)
#4
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):
http://codereview.appspot.com/6459079/diff/1/MoinMoin/forms.py#newcode16
MoinMoin/forms.py:16: from flatland import List
> it was like that to avoid merge conflicts...
ah
> what's the policy for import formatting in moin2?
no policy. older code uses multiple import statements or backslash line
continuation, newer uses parens.
> since we don't enforce the
> 78-char limit, the paren isn't a must.
Well, not strictly enforcing 78chars doesn't imply that lines can be / should be
almost endless.
Issue 6459079: BackReference widget
(Closed)
Created 12 years, 4 months ago by xiaq
Modified 12 years, 4 months ago
Reviewers: thomas.j.waldmann_googlemail.com, Reimar Bauer, spy
Base URL:
Comments: 5