Created to fix the feature request http://code.google.com/p/google-http-java-client/issues/detail?id=147 : Include properties files for Eclipse Android support to specify location of source jar.
On 2012/08/08 14:23:52, yanivi wrote: > I don't have time to review in any detail, ...
11 years, 8 months ago
(2012-08-09 14:35:43 UTC)
#3
On 2012/08/08 14:23:52, yanivi wrote:
> I don't have time to review in any detail, but can you please update the
> readme.html file also? Thanks!
Done.
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar So the annoying thing here is that the ...
11 years, 8 months ago
(2012-08-20 18:49:57 UTC)
#6
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar
So the annoying thing here is that the version of the library is included in the
file name and src value. I wonder if there is a better programmatic solution.
For src that's easy enough: just use ${project.version} and then use
<filtered>true</filtered> in the assembly.xml. But what do we do about the file
name? See if there is a Maven trick to solve this.
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-appengine-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-appengine-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-appengine-1.11.0-beta-SNAPSHOT-sources.jar
the appengine/servlet/java6 ones don't make sense for Android, so let's skip
those. similarly for jdo2, transaction, httpcore, httpclient, commons-logging.
take a look at the descriptor.json file in the zip file bundle for generated
Google APIs for a possibly more accurate list.
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-http-client-android2-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-http-client-android2-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-http-client-android2-1.11.0-beta-SNAPSHOT-sources.jar
missing google-http-client-android-1.11.0-beta-SNAPSHOT.jar.properties
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/20 18:49:57, yanivi wrote: > So the ...
11 years, 8 months ago
(2012-08-21 12:16:55 UTC)
#7
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/20 18:49:57, yanivi wrote:
> So the annoying thing here is that the version of the library is included in
the
> file name and src value. I wonder if there is a better programmatic solution.
> For src that's easy enough: just use ${project.version} and then use
> <filtered>true</filtered> in the assembly.xml. But what do we do about the
file
> name? See if there is a Maven trick to solve this.
Yes I tried looking for it when I created the CL but could not find anything. To
get around this the steps in release.html will make it easy to update both the
file name and the src value.
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-appengine-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-appengine-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-appengine-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/20 18:49:57, yanivi wrote:
> the appengine/servlet/java6 ones don't make sense for Android, so let's skip
> those. similarly for jdo2, transaction, httpcore, httpclient,
commons-logging.
> take a look at the descriptor.json file in the zip file bundle for generated
> Google APIs for a possibly more accurate list.
Yes good point. Done.
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-http-client-android2-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-http-client-android2-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-http-client-android2-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/20 18:49:57, yanivi wrote:
> missing google-http-client-android-1.11.0-beta-SNAPSHOT.jar.properties
This was added in patchset 3.
LGTM http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/21 12:16:55, rmistry wrote: > On ...
11 years, 8 months ago
(2012-08-22 20:33:48 UTC)
#8
LGTM
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/21 12:16:55, rmistry wrote:
> On 2012/08/20 18:49:57, yanivi wrote:
> > So the annoying thing here is that the version of the library is included in
> the
> > file name and src value. I wonder if there is a better programmatic
solution.
>
> > For src that's easy enough: just use ${project.version} and then use
> > <filtered>true</filtered> in the assembly.xml. But what do we do about the
> file
> > name? See if there is a Maven trick to solve this.
>
> Yes I tried looking for it when I created the CL but could not find anything.
To
> get around this the steps in release.html will make it easy to update both the
> file name and the src value.
[optional] I'd still prefer to use a variable for the src value using a filter
just because that one we do know how to solve
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-oauth-client-java6-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-oauth-client-java6-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-oauth-client-java6-1.11.0-beta-SNAPSHOT-sources.jar
can you please leave this one out also for now? it currently has nothing for
Android.
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/jackson-core-asl-1.9.4.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/jackson-core-asl-1.9.4.jar.properties:1:
src=../libs-sources/jackson-core-asl-1.9.4-sources.jar
1.9.9
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/protobuf-java-2.2.0.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/protobuf-java-2.2.0.jar.properties:1:
src=../libs-sources/protobuf-java-2.2.0-sources.jar
2.4.1
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/22 20:33:48, yanivi wrote: > On 2012/08/21 ...
11 years, 8 months ago
(2012-08-24 13:15:41 UTC)
#10
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/22 20:33:48, yanivi wrote:
> On 2012/08/21 12:16:55, rmistry wrote:
> > On 2012/08/20 18:49:57, yanivi wrote:
> > > So the annoying thing here is that the version of the library is included
in
> > the
> > > file name and src value. I wonder if there is a better programmatic
> solution.
> >
> > > For src that's easy enough: just use ${project.version} and then use
> > > <filtered>true</filtered> in the assembly.xml. But what do we do about
the
> > file
> > > name? See if there is a Maven trick to solve this.
> >
> > Yes I tried looking for it when I created the CL but could not find
anything.
> To
> > get around this the steps in release.html will make it easy to update both
the
> > file name and the src value.
>
> [optional] I'd still prefer to use a variable for the src value using a filter
> just because that one we do know how to solve
Done.
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/google-oauth-client-java6-1.11.0-beta-SNAPSHOT.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/google-oauth-client-java6-1.11.0-beta-SNAPSHOT.jar.properties:1:
src=../libs-sources/google-oauth-client-java6-1.11.0-beta-SNAPSHOT-sources.jar
On 2012/08/22 20:33:48, yanivi wrote:
> can you please leave this one out also for now? it currently has nothing for
> Android.
Done.
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/jackson-core-asl-1.9.4.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/jackson-core-asl-1.9.4.jar.properties:1:
src=../libs-sources/jackson-core-asl-1.9.4-sources.jar
On 2012/08/22 20:33:48, yanivi wrote:
> 1.9.9
Done.
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
File
google-api-client-assembly/android-properties/protobuf-java-2.2.0.jar.properties
(right):
http://codereview.appspot.com/6459059/diff/3003/google-api-client-assembly/an...
google-api-client-assembly/android-properties/protobuf-java-2.2.0.jar.properties:1:
src=../libs-sources/protobuf-java-2.2.0-sources.jar
On 2012/08/22 20:33:48, yanivi wrote:
> 2.4.1
Done.
Issue 6459059: Including properties file for Eclipse Android support
(Closed)
Created 11 years, 8 months ago by rmistry
Modified 11 years, 8 months ago
Reviewers: yanivi
Base URL: https://google-http-java-client.googlecode.com/hg/
Comments: 14