Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(909)

Issue 6459059: Including properties file for Eclipse Android support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rmistry
Modified:
11 years, 8 months ago
Reviewers:
yanivi
Base URL:
https://google-http-java-client.googlecode.com/hg/
Visibility:
Public.

Description

Created to fix the feature request http://code.google.com/p/google-http-java-client/issues/detail?id=147 : Include properties files for Eclipse Android support to specify location of source jar.

Patch Set 1 #

Patch Set 2 : review comments #

Total comments: 8

Patch Set 3 : hg pull -u #

Patch Set 4 : review comments #

Total comments: 6

Patch Set 5 : review comments #

Patch Set 6 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
A google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-api-client-android-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-api-client-android2-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-android-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-android2-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-android3-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-gson-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-jackson-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-http-client-protobuf-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/google-oauth-client-1.11.0-beta-SNAPSHOT.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/gson-2.1.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/guava-11.0.1.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/jackson-core-asl-1.9.9.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A google-api-client-assembly/android-properties/protobuf-java-2.4.1.jar.properties View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M google-api-client-assembly/assembly.xml View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M google-api-client-assembly/readme.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M pom.xml View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M release.html View 1 2 3 4 5 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11
rmistry
11 years, 8 months ago (2012-08-08 13:16:27 UTC) #1
yanivi
I don't have time to review in any detail, but can you please update the ...
11 years, 8 months ago (2012-08-08 14:23:52 UTC) #2
rmistry
On 2012/08/08 14:23:52, yanivi wrote: > I don't have time to review in any detail, ...
11 years, 8 months ago (2012-08-09 14:35:43 UTC) #3
yanivi
Please hg pull -u
11 years, 8 months ago (2012-08-16 20:09:50 UTC) #4
rmistry
On 2012/08/16 20:09:50, yanivi wrote: > Please hg pull -u Done.
11 years, 8 months ago (2012-08-20 13:31:36 UTC) #5
yanivi
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar So the annoying thing here is that the ...
11 years, 8 months ago (2012-08-20 18:49:57 UTC) #6
rmistry
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/20 18:49:57, yanivi wrote: > So the ...
11 years, 8 months ago (2012-08-21 12:16:55 UTC) #7
yanivi
LGTM http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/21 12:16:55, rmistry wrote: > On ...
11 years, 8 months ago (2012-08-22 20:33:48 UTC) #8
yanivi
please add google-api-client-android
11 years, 8 months ago (2012-08-23 17:37:12 UTC) #9
rmistry
http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties File google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties (right): http://codereview.appspot.com/6459059/diff/3001/google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties#newcode1 google-api-client-assembly/android-properties/google-api-client-1.11.0-beta-SNAPSHOT.jar.properties:1: src=../libs-sources/google-api-client-1.11.0-beta-SNAPSHOT-sources.jar On 2012/08/22 20:33:48, yanivi wrote: > On 2012/08/21 ...
11 years, 8 months ago (2012-08-24 13:15:41 UTC) #10
yanivi
11 years, 8 months ago (2012-08-24 13:21:52 UTC) #11
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b