Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(618)

Issue 6459047: keep itemtype and contenttype in Item and Content subclasses (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by xiaq
Modified:
12 years, 3 months ago
Reviewers:
thomas.j.waldmann, Reimar Bauer, waldi
Visibility:
Public.

Description

keep itemtype and contenttype in Item and Content subclasses

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -54 lines) Patch
M MoinMoin/items/__init__.py View 5 chunks +20 lines, -12 lines 3 comments Download
M MoinMoin/items/content.py View 15 chunks +69 lines, -42 lines 0 comments Download

Messages

Total messages: 3
xiaq
This is the part i stripped from http://codereview.appspot.com/6453060/. also @register decorator is now defined outside ...
12 years, 3 months ago (2012-08-06 02:14:31 UTC) #1
Reimar Bauer
question / comment http://codereview.appspot.com/6459047/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/6459047/diff/1/MoinMoin/items/__init__.py#newcode1 MoinMoin/items/__init__.py:1: # Copyright: 2012 MoinMoin:CheerXiao keep history, ...
12 years, 3 months ago (2012-08-08 07:17:32 UTC) #2
ThomasJWaldmann
12 years, 3 months ago (2012-08-09 12:08:39 UTC) #3
http://codereview.appspot.com/6459047/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/6459047/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:553: itemtype = u'default'
can be extended later, when needed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b