Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1022)

Issue 6458159: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Ian Hulin (gmail)
Modified:
11 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. The V2.17.0 definition of ly_module_lookup in module-scheme.cc uses two functions, scm_sym2var and scm_module_lookup_closure, which issue deprecation warnings in Guile V2.06. A call to the new Guile API function, scm_module_variable, provides the functionality for both deprecated routines, but has not been back-ported to Guile V1.8. This patch adds a conditionally-compiled shim function definition for scm_module_variable when running with a Guile version < V2.0, and changes ly_module_lookup to call scm_module_variable.

Patch Set 1 #

Patch Set 2 : declare scm_module_variable shim for Guile V1.8 as static - improves cell count nos in make check #

Patch Set 3 : Added GUILEV1 and GUILEV2 macros to guile-compatibility.hh, changed GUILEV1 code in module-scheme.cc #

Patch Set 4 : Revert to original line for ly_module_lookup GUILEV1 path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M flower/include/guile-compatibility.hh View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M lily/module-scheme.cc View 1 2 3 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 11
Ian Hulin (gmail)
Cleaned up garbage in Subject and Description Fields.
11 years, 7 months ago (2012-08-19 22:31:46 UTC) #1
Graham Percival
LGTM
11 years, 7 months ago (2012-08-21 11:51:53 UTC) #2
Patrick McCarty
LGTM
11 years, 7 months ago (2012-09-03 03:41:39 UTC) #3
dak
On 2012/09/03 03:41:39, Patrick McCarty wrote: > LGTM Let's not get this merged. ly_lily_module_constant ("module-variable") ...
11 years, 7 months ago (2012-09-03 05:39:57 UTC) #4
Patrick McCarty
On 2012/09/03 05:39:57, dak wrote: > On 2012/09/03 03:41:39, Patrick McCarty wrote: > > LGTM ...
11 years, 7 months ago (2012-09-03 07:25:20 UTC) #5
Ian Hulin (gmail)
On 2012/09/03 07:25:20, Patrick McCarty wrote: > On 2012/09/03 05:39:57, dak wrote: > > On ...
11 years, 6 months ago (2012-09-06 17:20:59 UTC) #6
dak
On 2012/09/06 17:20:59, Ian Hulin (gmail) wrote: > On 2012/09/03 07:25:20, Patrick McCarty wrote: > ...
11 years, 6 months ago (2012-09-06 18:07:53 UTC) #7
Ian Hulin (gmail)
On 2012/09/06 18:07:53, dak wrote: > On 2012/09/06 17:20:59, Ian Hulin (gmail) wrote: > > ...
11 years, 6 months ago (2012-09-06 23:24:04 UTC) #8
dak
On 2012/09/06 23:24:04, Ian Hulin (gmail) wrote: > On 2012/09/06 18:07:53, dak wrote: > > ...
11 years, 6 months ago (2012-09-08 09:13:17 UTC) #9
Ian Hulin (gmail)
On 2012/09/08 09:13:17, dak wrote: > On 2012/09/06 23:24:04, Ian Hulin (gmail) wrote: > > ...
11 years, 6 months ago (2012-09-08 17:03:34 UTC) #10
Ian Hulin (gmail)
11 years, 6 months ago (2012-09-25 11:23:30 UTC) #11
Closing Rietveld issue now that Tracker Issue 2758 has been verified.
Ian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b