Issue 6458126: Add 'Safe Draft' and 'Publish' buttons on BlogEntry item's ModifyForm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458126: Add 'Safe Draft' and 'Publish' buttons on BlogEntry item's ModifyForm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by spy

Modified:
12 years, 3 months ago

Reviewers:
Reimar Bauer

Visibility:
Public.

More Reviews

Description

Add 'Safe Draft' and 'Publish' buttons on BlogEntry item's ModifyForm.

Patch Set 2 : preload ptime with the current datetime #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -3 lines)			Patch
M	MoinMoin/forms.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	MoinMoin/items/__init__.py	View	1	4 chunks	+32 lines, -2 lines	0 comments	Download
A	MoinMoin/templates/modify_blog_entry.html	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reimar Bauer

some comment http://codereview.appspot.com/6458126/diff/1/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6458126/diff/1/MoinMoin/forms.py#newcode139 MoinMoin/forms.py:139: DateTime = (DateTimeUNIX.with_properties(widget=WIDGET_DATETIME, placeholder=_("YYYY-MM-DD HH:MM:SS"), helper=_("example: 2999-12-31 ...

12 years, 3 months ago (2012-08-14 05:20:01 UTC) #1

spy

12 years, 3 months ago (2012-08-14 09:16:05 UTC) #2

http://codereview.appspot.com/6458126/diff/1/MoinMoin/forms.py
File MoinMoin/forms.py (right):

http://codereview.appspot.com/6458126/diff/1/MoinMoin/forms.py#newcode139
MoinMoin/forms.py:139: DateTime =
(DateTimeUNIX.with_properties(widget=WIDGET_DATETIME, placeholder=_("YYYY-MM-DD
HH:MM:SS"), helper=_("example: 2999-12-31 23:59:59"))
On 2012/08/14 05:20:01, Reimar Bauer wrote:
> I would add a realistic example e.g. current year + 1
> e.g. 2013-12-31 23:59:59

okay :)

http://codereview.appspot.com/6458126/diff/1/MoinMoin/templates/common.js
File MoinMoin/templates/common.js (right):

http://codereview.appspot.com/6458126/diff/1/MoinMoin/templates/common.js#new...
MoinMoin/templates/common.js:501: now.getUTCMonth() + 1,
On 2012/08/14 05:20:01, Reimar Bauer wrote:
> why + 1 ?

"The getMonth() method returns the month (from 0 to 11) for the specified date,
according to local time."

Perhaps it helps to work with drop-down lists of months.

Expand All Messages | Collapse All Messages