code review 6458104: cmd/dist: always build go_bootstrap in softfp mode on l...

cmd/dist: always build go_bootstrap in softfp mode on linux/arm

CL 6446105 added the ability for the go tool to supply the correct value of GOARM automatically. However the problem of building the bootstrap commands correctly remains. This change causes the dist tool to always build the bootstrap commands in softfp mode on linux/arm.

This does imply that on ARMv6 systems and above, a portion of the bootstrap process will be using softfp math. Benchmarking on my pandaboard before and after this CL, the times were identical at 4m30s.

[minux1, 2012-08-09 09:03:36]

http://codereview.appspot.com/6458104/diff/2001/src/cmd/dist/build.c
File src/cmd/dist/build.c (right):

http://codereview.appspot.com/6458104/diff/2001/src/cmd/dist/build.c#newcode624
src/cmd/dist/build.c:624: if (streq(gochar, "5"))
no space between if and open-paren please.

[dave_cheney.net, 2012-08-09 09:39:42]

Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2012-08-09 09:45:06]

LGTM; +rsc

[rsc, 2012-08-09 19:42:02]

NOT LGTM

I will reply to your mail thread.

[dave_cheney.net, 2012-08-09 23:48:58]

*** Abandoned ***