Content.create

Content.create

[xiaq, 2012-08-06 03:08:25]

This patch set adds a classmethod create to Content.

http://codereview.appspot.com/6458084/diff/1/MoinMoin/items/_tests/test_Conte...
File MoinMoin/items/_tests/test_Content.py (left):

http://codereview.appspot.com/6458084/diff/1/MoinMoin/items/_tests/test_Conte...
MoinMoin/items/_tests/test_Content.py:30: # only.
I removed this comment since even when testing content only, it's better to say
Item.create(name).content.

Content constantly relies on an associated Item instance (self.item of Content)
to perform actions, Thus a Content created with
Content.create(contenttype='foobar', item=None), (item=None being default
arguement value) is quite restricted.

[Reimar Bauer, 2012-08-08 07:28:32]

ok

http://codereview.appspot.com/6458084/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (left):

http://codereview.appspot.com/6458084/diff/1/MoinMoin/items/__init__.py#oldco...
MoinMoin/items/__init__.py:193: logging.debug("Content class {0!r} handles
{1!r}".format(content.__class__, contenttype))
hmm, someone has added a looging here because of a problem? 
why removing it? instead of shifting?

seen - it is just moved to Content.create: OK

[ThomasJWaldmann, 2012-08-09 11:42:41]

looks ok