Issue 6458080: uniquely name FS functions, add lighting effects to unit test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6458080: uniquely name FS functions, add lighting effects to unit test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : fixup #

Total comments: 3

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -192 lines)			Patch
M	src/effects/SkLightingImageFilter.cpp	View	1 2	17 chunks	+185 lines, -56 lines	1 comment	Download
M	src/gpu/gl/GrGLSL.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.cpp	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2	3 chunks	+28 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderVar.h	View	1	6 chunks	+19 lines, -2 lines	2 comments	Download
M	tests/GLProgramsTest.cpp	View	1 2	5 chunks	+19 lines, -128 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TomH

LGTM. http://codereview.appspot.com/6458080/diff/5001/src/effects/SkLightingImageFilter.cpp File src/effects/SkLightingImageFilter.cpp (right): http://codereview.appspot.com/6458080/diff/5001/src/effects/SkLightingImageFilter.cpp#newcode374 src/effects/SkLightingImageFilter.cpp:374: virtual void emitFuncs(GrGLShaderBuilder* builder) {} Change in signature ...

12 years, 4 months ago (2012-08-06 20:26:44 UTC) #2

bsalomon

http://codereview.appspot.com/6458080/diff/5001/src/gpu/gl/GrGLShaderVar.h File src/gpu/gl/GrGLShaderVar.h (left): http://codereview.appspot.com/6458080/diff/5001/src/gpu/gl/GrGLShaderVar.h#oldcode235 src/gpu/gl/GrGLShaderVar.h:235: out->append(";\n"); On 2012/08/06 20:26:44, TomH wrote: > Why did ...

12 years, 4 months ago (2012-08-06 20:50:29 UTC) #3

Ah, right, argument lists.

Expand All Messages | Collapse All Messages