Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 6458072: code review 6458072: goprotobuf: JSON helpers for enum types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by dsymonds
Modified:
13 years, 4 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

goprotobuf: JSON helpers for enum types.

Patch Set 1 #

Patch Set 2 : diff -r 0c7c0b7f984e https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 0c7c0b7f984e https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 8444dbcb9a81 https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -226 lines) Patch
M proto/all_test.go View 1 2 chunks +20 lines, -1 line 0 comments Download
M proto/lib.go View 1 2 chunks +30 lines, -0 lines 0 comments Download
M proto/testdata/test.pb.go View 1 6 chunks +58 lines, -1 line 0 comments Download
M protoc-gen-go/descriptor/descriptor.pb.go View 1 2 26 chunks +67 lines, -217 lines 0 comments Download
M protoc-gen-go/generator/generator.go View 1 4 chunks +25 lines, -3 lines 0 comments Download
M protoc-gen-go/plugin/plugin.pb.go View 1 1 chunk +4 lines, -2 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 2 3 5 chunks +47 lines, -1 line 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 2 3 5 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
13 years, 4 months ago (2012-08-03 04:44:03 UTC) #1
rsc
LGTM
13 years, 4 months ago (2012-08-03 19:18:45 UTC) #2
dsymonds
13 years, 4 months ago (2012-08-04 00:07:00 UTC) #3
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=88ccec1be991 ***

goprotobuf: JSON helpers for enum types.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/6458072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b