LGTM On Wed, Aug 1, 2012 at 4:58 PM, <robertphillips@google.com> wrote: > Reviewers: bsalomon, > > Description: > This will require rebaselining of complexclip2* & simplaaaclip* > > Please review this at http://codereview.appspot.com/**6458064/<http://codereview.appspot.com/6458064/> > > Affected files: > M gm/complexclip2.cpp > M gm/simpleaaclip.cpp > > > Index: gm/simpleaaclip.cpp > ==============================**==============================**======= > --- gm/simpleaaclip.cpp (revision 4901) > +++ gm/simpleaaclip.cpp (working copy) > @@ -53,10 +53,10 @@ > : fGeomType(geomType) { > > // offset the rects a bit so we get anti-aliasing in the rect case > - fBase.set(SkFloatToScalar(100.**5f), > - SkFloatToScalar(100.5f), > - SkFloatToScalar(150.5f), > - SkFloatToScalar(150.5f)); > + fBase.set(SkFloatToScalar(100.**65f), > + SkFloatToScalar(100.65f), > + SkFloatToScalar(150.65f), > + SkFloatToScalar(150.65f)); > fRect = fBase; > fRect.inset(5, 5); > fRect.offset(25, 25); > Index: gm/complexclip2.cpp > ==============================**==============================**======= > --- gm/complexclip2.cpp (revision 4901) > +++ gm/complexclip2.cpp (working copy) > @@ -21,19 +21,19 @@ > this->setBGColor(**SkColorSetRGB(0xDD,0xA0,0xDD))**; > > // offset the rects a bit so we get antialiasing even in the rect > case > - SkScalar xA = SkFloatToScalar(0.5f); > - SkScalar xB = SkFloatToScalar(10.5f); > - SkScalar xC = SkFloatToScalar(20.5f); > - SkScalar xD = SkFloatToScalar(30.5f); > - SkScalar xE = SkFloatToScalar(40.5f); > - SkScalar xF = SkFloatToScalar(50.5f); > + SkScalar xA = SkFloatToScalar(0.65f); > + SkScalar xB = SkFloatToScalar(10.65f); > + SkScalar xC = SkFloatToScalar(20.65f); > + SkScalar xD = SkFloatToScalar(30.65f); > + SkScalar xE = SkFloatToScalar(40.65f); > + SkScalar xF = SkFloatToScalar(50.65f); > > - SkScalar yA = SkFloatToScalar(0.5f); > - SkScalar yB = SkFloatToScalar(10.5f); > - SkScalar yC = SkFloatToScalar(20.5f); > - SkScalar yD = SkFloatToScalar(30.5f); > - SkScalar yE = SkFloatToScalar(40.5f); > - SkScalar yF = SkFloatToScalar(50.5f); > + SkScalar yA = SkFloatToScalar(0.65f); > + SkScalar yB = SkFloatToScalar(10.65f); > + SkScalar yC = SkFloatToScalar(20.65f); > + SkScalar yD = SkFloatToScalar(30.65f); > + SkScalar yE = SkFloatToScalar(40.65f); > + SkScalar yF = SkFloatToScalar(50.65f); > > fWidth = xF - xA; > fHeight = yF - yA; > > >
committed as r4905