Issue 6457088: Add Blog and BlogEntry itemtype classes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6457088: Add Blog and BlogEntry itemtype classes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by spy

Modified:
11 years, 9 months ago

Reviewers:
xiaq, thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Add Blog and BlogEntry itemtype classes.

Patch Set 2 : Override _ModifyForm class. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
M	MoinMoin/items/__init__.py	View	1	3 chunks	+31 lines, -2 lines	0 comments	Download
A	MoinMoin/templates/modify_blog_entry_meta.html	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	MoinMoin/templates/modify_blog_meta.html	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ThomasJWaldmann

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newcode669 MoinMoin/items/__init__.py:669: ptime = DateTime.using(label=L_('Publish time (UTC)'), optional=True) maybe ask a ...

11 years, 9 months ago (2012-08-07 15:12:31 UTC) #1

xiaq

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newcode678 MoinMoin/items/__init__.py:678: def ModifyForm(self): Consider overriding _ModifyForm class instead. http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newcode693 MoinMoin/items/__init__.py:693: ...

11 years, 9 months ago (2012-08-08 03:54:03 UTC) #2

spy

11 years, 9 months ago (2012-08-08 09:06:09 UTC) #3

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py
File MoinMoin/items/__init__.py (right):

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:669: ptime = DateTime.using(label=L_('Publish time
(UTC)'), optional=True)
On 2012/08/07 15:12:31, ThomasJWaldmann wrote:
> maybe ask a native speaker whether "Publish time" is ok or whether it should
be
> "Publication time".

renamed to "Publication time"

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:674: """
On 2012/08/07 15:12:31, ThomasJWaldmann wrote:
> either add something in there or kill the docstring.

killed for now

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:678: def ModifyForm(self):
On 2012/08/08 03:54:04, xiaq wrote:
> Consider overriding _ModifyForm class instead.

rewrote, see next changeset

http://codereview.appspot.com/6457088/diff/1/MoinMoin/items/__init__.py#newco...
MoinMoin/items/__init__.py:689: """
On 2012/08/07 15:12:31, ThomasJWaldmann wrote:
> either add something in there or kill the docstring.

killed for now

Expand All Messages | Collapse All Messages