Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5487)

Issue 6457061: Added dev- & canv- prefixes to Ganesh bounding boxes to indicate coordinate space (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This cleanup was suggested in http://codereview.appspot.com/6445052/ but was large enough to deserve its own CL.

Patch Set 1 #

Patch Set 2 : Cleaned up a bit #

Total comments: 4

Patch Set 3 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -172 lines) Patch
M include/core/SkClipStack.h View 2 chunks +5 lines, -5 lines 0 comments Download
M include/gpu/GrClip.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkClipStack.cpp View 1 3 chunks +12 lines, -10 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 7 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/GrClip.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 29 chunks +88 lines, -81 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 4 chunks +31 lines, -28 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +15 lines, -14 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M tests/ClipCacheTest.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M tests/ClipStackTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 4 months ago (2012-07-31 14:44:09 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrClipMaskManager.cpp#newcode469 src/gpu/GrClipMaskManager.cpp:469: void canvas_to_device(SkRect* rect, const SkIPoint& origin) { If ...
12 years, 4 months ago (2012-07-31 14:50:31 UTC) #2
robertphillips
12 years, 4 months ago (2012-07-31 15:18:47 UTC) #3
committed as r4856

http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrClipMaskManager.cpp...
src/gpu/GrClipMaskManager.cpp:469: void canvas_to_device(SkRect* rect, const
SkIPoint& origin) {
On 2012/07/31 14:50:31, bsalomon wrote:
> If we're not calling this then it seems like we can kill it

Done.

http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrTextContext.cpp
File src/gpu/GrTextContext.cpp (right):

http://codereview.appspot.com/6457061/diff/2001/src/gpu/GrTextContext.cpp#new...
src/gpu/GrTextContext.cpp:90: // convervativeBound starts off in canvas
coordinates here
On 2012/07/31 14:50:31, bsalomon wrote:
> Can this call the helper that does the conversion?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b