Issue 6455081: Superfluous titling commands (2710)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6455081: Superfluous titling commands (2710) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Trevor Daniels

Modified:
11 years, 9 months ago

Reviewers:
Graham Percival, t.daniels

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Superfluous titling commands (2710) Remove both \larger and \smaller in subtitle as these simply cancel each other. Rearrange the title markup commands for consistency. These changes should not affect any existing scores.

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ly/titling-init.ly	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival

assuming that you've compared a pdf of before&after, LGTM.

11 years, 9 months ago (2012-08-03 09:33:31 UTC) #1

t.daniels_treda.co.uk

<graham@percival-music.ca> wrote Friday, August 03, 2012 10:33 AM > assuming that you've compared a pdf ...

11 years, 9 months ago (2012-08-03 09:39:48 UTC) #2

Trevor Daniels

11 years, 9 months ago (2012-08-06 09:49:07 UTC) #3

Pushed to staging as
28b50ab376b2a17c65999281fadc4d89f4ae1ee1
Closing

Expand All Messages | Collapse All Messages