Issue 6454151: Reduce number of paths created by benchs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454151: Reduce number of paths created by benchs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -54 lines)			Patch
	M	bench/PathBench.cpp	View		7 chunks	+79 lines, -54 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm http://codereview.appspot.com/6454151/diff/1/bench/PathBench.cpp File bench/PathBench.cpp (right): http://codereview.appspot.com/6454151/diff/1/bench/PathBench.cpp#newcode347 bench/PathBench.cpp:347: // must be a pow 2 kPathCnt = ...

11 years, 10 months ago (2012-08-14 17:44:52 UTC) #2

bsalomon

11 years, 10 months ago (2012-08-14 17:50:09 UTC) #3

Closed with r5088.

http://codereview.appspot.com/6454151/diff/1/bench/PathBench.cpp
File bench/PathBench.cpp (right):

http://codereview.appspot.com/6454151/diff/1/bench/PathBench.cpp#newcode347
bench/PathBench.cpp:347: // must be a pow 2
On 2012/08/14 17:44:52, reed1 wrote:
> kPathCnt = 1 << 5 ?

Done.

Expand All Messages | Collapse All Messages