Issue 6454137: Add path benchmarks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454137: Add path benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bsalomon

Modified:
11 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : update #

Total comments: 4

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+459 lines, -1 line)			Patch
M	bench/PathBench.cpp	View	1	3 chunks	+422 lines, -0 lines	2 comments	Download
M	bench/SkBenchmark.h	View		2 chunks	+14 lines, -1 line	0 comments	Download
M	bench/SkBenchmark.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	bench/benchmain.cpp	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	include/core/SkPath.h	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Adds a bunch of benchmarks around creating, transforming, testing path equality, and concatting paths. Also ...

11 years, 11 months ago (2012-08-10 20:18:40 UTC) #1

reed1

lgtm w/ question about naming and arrays http://codereview.appspot.com/6454137/diff/2001/bench/PathBench.cpp File bench/PathBench.cpp (right): http://codereview.appspot.com/6454137/diff/2001/bench/PathBench.cpp#newcode250 bench/PathBench.cpp:250: int pCnt; ...

11 years, 11 months ago (2012-08-13 13:21:11 UTC) #2

bsalomon

11 years, 11 months ago (2012-08-13 14:04:59 UTC) #3

Committed with both suggestions at r5054.

http://codereview.appspot.com/6454137/diff/2001/bench/PathBench.cpp
File bench/PathBench.cpp (right):

http://codereview.appspot.com/6454137/diff/2001/bench/PathBench.cpp#newcode250
bench/PathBench.cpp:250: int pCnt;
On 2012/08/13 13:21:11, reed1 wrote:
> use array for pCnt? at least its more concise to read...

Done.

http://codereview.appspot.com/6454137/diff/2001/include/core/SkPath.h
File include/core/SkPath.h (right):

http://codereview.appspot.com/6454137/diff/2001/include/core/SkPath.h#newcode868
include/core/SkPath.h:868: friend class SkAutoDisableOvalCheck;
On 2012/08/13 13:21:11, reed1 wrote:
> Should we have a more obnoxious name for these odd friendings? e.g.
> SkBench_AddPathTest?

Done.

Expand All Messages | Collapse All Messages