Issue 6454114: Linux->GNU/Linux (Issue 2651)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454114: Linux->GNU/Linux (Issue 2651) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by PhilEHolmes

Modified:
11 years, 8 months ago

Reviewers:
Graham Percival, dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Updates all the instances of linux that I can find in the English docs to GNU/Linux.

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	Documentation/contributor/administration.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/contributor/programming-work.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/contributor/quick-start.itexi	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Documentation/contributor/source-code.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/learning/tweaks.itely	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/usage/running.itely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/usage/suggestions.itely	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Documentation/web/download.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/web/introduction.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	flower/libc-extension.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	scripts/build/create-weblinks-itexi.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Graham Percival

11 years, 8 months ago (2012-08-07 14:03:20 UTC) #2

LGTM, one thing to fix then please push directly to staging.

http://codereview.appspot.com/6454114/diff/1/flower/libc-extension.cc
File flower/libc-extension.cc (right):

http://codereview.appspot.com/6454114/diff/1/flower/libc-extension.cc#newcode58
flower/libc-extension.cc:58: The prototype is not in accordance with the
GNU/Linux Programmer's
"Linux Programmer's manual" is a title of a book, so adding GNU/ is not
appropriate in this case.

Expand All Messages | Collapse All Messages