Issue 6454092: Change GET to POST if URI is too long.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454092: Change GET to POST if URI is too long. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by jcgregorio_google

Modified:
12 years, 1 month ago

Reviewers:
jcgregorio_google, Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 3 : extend test #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
	M	apiclient/http.py	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
	M	tests/test_http.py	View	1 2	3 chunks	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ali Afshar

http://codereview.appspot.com/6454092/diff/4/tests/test_http.py File tests/test_http.py (right): http://codereview.appspot.com/6454092/diff/4/tests/test_http.py#newcode754 tests/test_http.py:754: self.assertEqual('q=' + 'a' * MAX_URI_LENGTH, response) Can you add ...

12 years, 1 month ago (2012-08-03 16:00:53 UTC) #2

jcgregorio_google

12 years, 1 month ago (2012-08-03 16:31:35 UTC) #3

jcgregorio_google

12 years, 1 month ago (2012-08-03 16:49:06 UTC) #5

On 2012/08/03 16:37:00, Ali Afshar wrote:
> LGTM

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=7d1515ca91f...

Expand All Messages | Collapse All Messages