Issue 6454079: [ASan] Add support for running unit tests by lit (as a part of 'make check-asan' command)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6454079: [ASan] Add support for running unit tests by lit (as a part of 'make check-asan' command) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by samsonov

Modified:
12 years, 6 months ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 : z #

Total comments: 8

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -10 lines)			Patch
M	lib/asan/CMakeLists.txt	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	lib/asan/lit_tests/CMakeLists.txt	View	1 chunk	+28 lines, -6 lines	6 comments	Download
A	lib/asan/lit_tests/Unit/lit.cfg	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	lib/asan/lit_tests/Unit/lit.site.cfg.in	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	lib/asan/lit_tests/lit.site.cfg.in	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/asan/tests/CMakeLists.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A	lib/lit.common.unit.cfg	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

chandlerc

Some nit picky comments about structuring this... http://codereview.appspot.com/6454079/diff/10/lib/asan/CMakeLists.txt File lib/asan/CMakeLists.txt (right): http://codereview.appspot.com/6454079/diff/10/lib/asan/CMakeLists.txt#newcode4 lib/asan/CMakeLists.txt:4: set(ASAN_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) ...

12 years, 6 months ago (2012-08-07 08:00:14 UTC) #1

samsonov

12 years, 6 months ago (2012-08-07 09:01:16 UTC) #2

r161406, thanks!

http://codereview.appspot.com/6454079/diff/10/lib/asan/CMakeLists.txt
File lib/asan/CMakeLists.txt (right):

http://codereview.appspot.com/6454079/diff/10/lib/asan/CMakeLists.txt#newcode4
lib/asan/CMakeLists.txt:4: set(ASAN_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
On 2012/08/07 08:00:14, chandlerc wrote:
> I would just sink these into the lit_tests CMakeLists.txt, and append an '/..'
> suffix.

Done.

http://codereview.appspot.com/6454079/diff/10/lib/asan/lit_tests/CMakeLists.txt
File lib/asan/lit_tests/CMakeLists.txt (right):

http://codereview.appspot.com/6454079/diff/10/lib/asan/lit_tests/CMakeLists.t...
lib/asan/lit_tests/CMakeLists.txt:14: if (LLVM_INCLUDE_TESTS)
On 2012/08/07 08:00:14, chandlerc wrote:
> no space before (

Done.

http://codereview.appspot.com/6454079/diff/10/lib/asan/lit_tests/CMakeLists.t...
lib/asan/lit_tests/CMakeLists.txt:22: set (ASAN_TEST_ROOT
${CMAKE_CURRENT_BINARY_DIR})
On 2012/08/07 08:00:14, chandlerc wrote:
> no space before (
> 
> (i don't actually care, but trying to be consistent)

Done.

http://codereview.appspot.com/6454079/diff/10/lib/asan/lit_tests/CMakeLists.t...
lib/asan/lit_tests/CMakeLists.txt:22: set (ASAN_TEST_ROOT
${CMAKE_CURRENT_BINARY_DIR})
On 2012/08/07 08:00:14, chandlerc wrote:
> no space before (
> 
> (i don't actually care, but trying to be consistent)

Done.

Expand All Messages | Collapse All Messages