Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1340)

Issue 6453127: Extended Inst counting to find "unknown" leaked object (SkTMaskGamma) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by robertphillips
Modified:
11 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Extended Inst counting to find "unknown" leaked object (SkTMaskGamma)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added SkSurface.cpp & SkImage.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -593 lines) Patch
M include/core/SkImage.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkInstCnt.h View 3 chunks +11 lines, -4 lines 0 comments Download
M include/core/SkSurface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/utils/SkBoundaryPatch.h View 2 chunks +5 lines, -0 lines 0 comments Download
M include/utils/SkLayer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/views/SkEventSink.h View 2 chunks +5 lines, -1 line 0 comments Download
M include/views/SkView.h View 2 chunks +8 lines, -0 lines 0 comments Download
M include/views/animated/SkWidgetViews.h View 2 chunks +4 lines, -0 lines 0 comments Download
M samplecode/SampleApp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmapHeap.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkMaskGamma.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkPictureFlat.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPtrRecorder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkPtrRecorder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkScalerContext.cpp View 3 chunks +9 lines, -7 lines 0 comments Download
M src/image/SkImage.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkSurface.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkBoundaryPatch.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/utils/SkLayer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/views/SkEventSink.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/views/SkView.cpp View 13 chunks +356 lines, -353 lines 0 comments Download
M src/views/animated/SkWidgetViews.cpp View 6 chunks +230 lines, -228 lines 0 comments Download
M tests/AAClipTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/RefDictTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/Test.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/Test.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/UtilsTest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
robertphillips
http://codereview.appspot.com/6453127/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): http://codereview.appspot.com/6453127/diff/1/include/core/SkImage.h#newcode39 include/core/SkImage.h:39: public: .cpp not checked in? http://codereview.appspot.com/6453127/diff/1/include/core/SkSurface.h File include/core/SkSurface.h (right): ...
11 years, 10 months ago (2012-08-16 10:54:23 UTC) #1
reed1
lgtm http://codereview.appspot.com/6453127/diff/1/include/core/SkImage.h File include/core/SkImage.h (right): http://codereview.appspot.com/6453127/diff/1/include/core/SkImage.h#newcode39 include/core/SkImage.h:39: public: On 2012/08/16 10:54:23, robertphillips wrote: > .cpp ...
11 years, 10 months ago (2012-08-16 13:28:14 UTC) #2
robertphillips
11 years, 10 months ago (2012-08-16 14:58:41 UTC) #3
committed as r5123
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b