Issue 6453096: Redo commandline completion on edit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453096: Redo commandline completion on edit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Jasvir

Modified:
12 years, 8 months ago

Reviewers:
mzero, thecomfyshell

Visibility:
Public.

More Reviews

Description

Previously editing the commandline would leave the completion markup. This change fixes that

Patch Set 2 : Change to using keyup instead of keydown for autorepeated characters #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	static/js/shell.js	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mzero

http://codereview.appspot.com/6453096/diff/1/static/js/shell.js File static/js/shell.js (right): http://codereview.appspot.com/6453096/diff/1/static/js/shell.js#newcode297 static/js/shell.js:297: function requestRunComplete() { what about auto-repeating keys? This will ...

13 years, 1 month ago (2012-08-08 22:02:53 UTC) #2

LGTM

Expand All Messages | Collapse All Messages