Issue 6453079: Skipping MSAA tests on Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453079: Skipping MSAA tests on Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, EricB

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

r4912 altered GM's logic so a failure to allocate an MSAA-capable GrContext would be reported as an error. Since we do not support MSAA on any Android device this CL disables MSAA testing on Android.

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	gm/gmmain.cpp	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM http://codereview.appspot.com/6453079/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): http://codereview.appspot.com/6453079/diff/1/gm/gmmain.cpp#newcode759 gm/gmmain.cpp:759: #endif // SK_SUPPORT_XPS yikes, thanks!

11 years, 11 months ago (2012-08-02 17:54:06 UTC) #2

committed as r4926

Expand All Messages | Collapse All Messages