Issue 6453066: Fixed minor memory leaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6453066: Fixed minor memory leaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by robertphillips

Modified:
12 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, Leon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 3 : Cleaned up some more #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -6 lines)			Patch
M	samplecode/SampleDecode.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/debug/GrDebugGL.h	View	1 2	2 chunks	+22 lines, -3 lines	2 comments	Download
M	src/gpu/gl/debug/GrDebugGL.cpp	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/gpu/gl/debug/GrGLCreateDebugInterface.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

LGTM http://codereview.appspot.com/6453066/diff/1005/src/gpu/gl/debug/GrDebugGL.h File src/gpu/gl/debug/GrDebugGL.h (right): http://codereview.appspot.com/6453066/diff/1005/src/gpu/gl/debug/GrDebugGL.h#newcode88 src/gpu/gl/debug/GrDebugGL.h:88: GrAssert(0 < gStaticRefCount); gStaticRefCount > 0 ?

12 years, 2 months ago (2012-07-31 19:11:53 UTC) #2

robertphillips

12 years, 2 months ago (2012-07-31 19:23:22 UTC) #3

committed as r4866

http://codereview.appspot.com/6453066/diff/1005/src/gpu/gl/debug/GrDebugGL.h
File src/gpu/gl/debug/GrDebugGL.h (right):

http://codereview.appspot.com/6453066/diff/1005/src/gpu/gl/debug/GrDebugGL.h#...
src/gpu/gl/debug/GrDebugGL.h:88: GrAssert(0 < gStaticRefCount);
Aren't we always supposed to have the un-modifiable value on the LHS?

Expand All Messages | Collapse All Messages