Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8032)

Issue 6453044: 4 issues related to rational duration factors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by dak
Modified:
11 years, 8 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

4 issues related to rational duration factors. Since it would take 2 weeks to shoo them through in order of dependency, I am wrapping this into a single issue (first upload includes patch from issue 2692 and will need rebasing once that went into master). The various commits touch different files, though. Implement ly:duration-scale and let ly:make-duration accept rational factors lily/duration-scheme.cc | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) Replace some uses of ly:duration-factor scm/define-event-classes.scm | 3 +-- scm/music-functions.scm | 8 +++----- scm/safe-lily.scm | 1 + 3 files changed, 5 insertions(+), 7 deletions(-) scm/song.scm: fix faulty calculation of durations. scm/song.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Fix display of tuplet music, also when nested. scm/define-music-display-methods.scm | 32 +++++++++++++++----------------- scm/display-lily.scm | 3 +-- 2 files changed, 16 insertions(+), 19 deletions(-) Add display test for nested tuplet music. input/regression/display-lily-tests.ly | 1 + 1 file changed, 1 insertion(+)

Patch Set 1 #

Patch Set 2 : Trying a reupload to make issue register. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -54 lines) Patch
M input/regression/display-lily-tests.ly View 1 chunk +1 line, -0 lines 0 comments Download
M lily/duration-scheme.cc View 4 chunks +20 lines, -7 lines 0 comments Download
M lily/include/lily-guile.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lily-guile.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M lily/moment-scheme.cc View 1 chunk +34 lines, -14 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +1 line, -2 lines 0 comments Download
M scm/define-music-display-methods.scm View 3 chunks +15 lines, -17 lines 0 comments Download
M scm/display-lily.scm View 1 chunk +1 line, -2 lines 0 comments Download
M scm/music-functions.scm View 2 chunks +3 lines, -5 lines 0 comments Download
M scm/safe-lily.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/song.scm View 1 chunk +1 line, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b