Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(401)

Issue 6452064: Add SK_SUPPORT_GPU macro to allow building a gpu-less skia (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by bsalomon
Modified:
12 years, 10 months ago
Reviewers:
TomH, reed1
CC:
skia-review_googlegroups.com, EricB, rmistry
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adds a GPU-less build. It is controlled by config macro SK_SUPPORT_GPU. It defaults to 1. If it is set to 0 we build without any gpu support. Users of the gyp build system can do a GPU-less build via: GYP_DEFINES=skia_gpu=0

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : warning fix #

Patch Set 5 : make Mac SampleApp work (sort of) #

Patch Set 6 : revert image files unintentionally uploaded in patchset 5 #

Patch Set 7 : Merge with gradient changes #

Patch Set 8 : cleanup #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -205 lines) Patch
M bench/BenchTimer.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M bench/BenchTimer.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M bench/benchmain.cpp View 1 2 3 4 5 6 7 12 chunks +43 lines, -22 lines 0 comments Download
M gm/gmmain.cpp View 1 2 3 4 5 6 7 15 chunks +70 lines, -52 lines 0 comments Download
M gm/ninepatchstretch.cpp View 1 2 3 4 5 6 7 2 chunks +9 lines, -2 lines 0 comments Download
M gm/texdata.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 3 4 5 6 4 chunks +9 lines, -4 lines 0 comments Download
M gyp/bench.gyp View 1 2 3 4 5 6 5 chunks +22 lines, -6 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 4 5 6 1 chunk +11 lines, -1 line 0 comments Download
M gyp/common_variables.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/debugger.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gyp View 1 2 3 4 5 6 2 chunks +10 lines, -2 lines 0 comments Download
M gyp/gm.gyp View 1 2 3 4 5 6 3 chunks +10 lines, -4 lines 0 comments Download
M gyp/gpu.gyp View 1 2 3 4 5 6 1 chunk +25 lines, -0 lines 0 comments Download
M gyp/shapeops_demo.gyp View 1 2 3 4 5 6 2 chunks +6 lines, -2 lines 0 comments Download
M gyp/shapeops_edge.gyp View 1 2 3 4 5 6 2 chunks +11 lines, -3 lines 0 comments Download
M gyp/tests.gyp View 1 2 3 4 5 6 2 chunks +11 lines, -3 lines 0 comments Download
M gyp/views.gyp View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M include/config/SkUserConfig.h View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M include/core/SkPostConfig.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M include/views/SkOSWindow_Mac.h View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 2 3 4 5 6 7 3 chunks +9 lines, -3 lines 0 comments Download
M samplecode/SampleApp.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 6 7 19 chunks +65 lines, -20 lines 0 comments Download
M samplecode/SampleBitmapRect.cpp View 1 2 3 4 5 6 1 chunk +9 lines, -1 line 0 comments Download
M samplecode/SampleNinePatch.cpp View 1 2 3 4 5 6 7 3 chunks +11 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 3 4 5 6 7 13 chunks +42 lines, -5 lines 2 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 2 3 4 5 6 3 chunks +6 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M src/views/mac/SkNSView.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 2 3 4 5 6 7 9 chunks +81 lines, -43 lines 2 comments Download
M src/views/mac/SkOSWindow_Mac.mm View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 2 3 4 5 6 7 10 chunks +24 lines, -12 lines 0 comments Download
M tests/ClipCacheTest.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
M tests/GLInterfaceValidation.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M tests/GrMemoryPoolTest.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 2 3 4 5 6 2 chunks +8 lines, -3 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M tests/Test.cpp View 1 2 3 4 5 6 3 chunks +10 lines, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 2 3 4 5 6 7 5 chunks +15 lines, -3 lines 2 comments Download

Messages

Total messages: 6
bsalomon
This isn't finished yet. The idea is to add a new build macro SK_BUILD_GPU. It ...
12 years, 10 months ago (2012-07-30 21:30:01 UTC) #1
justinlin
http://codereview.appspot.com/6452064/diff/1/src/effects/gradients/SkRadialGradient.cpp File src/effects/gradients/SkRadialGradient.cpp (right): http://codereview.appspot.com/6452064/diff/1/src/effects/gradients/SkRadialGradient.cpp#newcode250 src/effects/gradients/SkRadialGradient.cpp:250: #if SK_BUILD_GPU Out of curiosity: are you supposed to ...
12 years, 10 months ago (2012-07-30 21:47:50 UTC) #2
bsalomon
On 2012/07/30 21:47:50, justinlin wrote: > http://codereview.appspot.com/6452064/diff/1/src/effects/gradients/SkRadialGradient.cpp > File src/effects/gradients/SkRadialGradient.cpp (right): > > http://codereview.appspot.com/6452064/diff/1/src/effects/gradients/SkRadialGradient.cpp#newcode250 > ...
12 years, 10 months ago (2012-08-01 13:22:37 UTC) #3
bsalomon
ping
12 years, 10 months ago (2012-08-01 19:26:24 UTC) #4
TomH
LGTM, if uglier than one would hope. http://codereview.appspot.com/6452064/diff/10017/src/effects/SkLightingImageFilter.cpp File src/effects/SkLightingImageFilter.cpp (right): http://codereview.appspot.com/6452064/diff/10017/src/effects/SkLightingImageFilter.cpp#newcode509 src/effects/SkLightingImageFilter.cpp:509: return SkNEW(GrGLDistantLight); ...
12 years, 10 months ago (2012-08-01 20:05:46 UTC) #5
bsalomon
12 years, 10 months ago (2012-08-02 14:06:29 UTC) #6
Landed at r4912.

http://codereview.appspot.com/6452064/diff/10017/src/effects/SkLightingImageF...
File src/effects/SkLightingImageFilter.cpp (right):

http://codereview.appspot.com/6452064/diff/10017/src/effects/SkLightingImageF...
src/effects/SkLightingImageFilter.cpp:509: return SkNEW(GrGLDistantLight);
On 2012/08/01 20:05:46, TomH wrote:
> nit: over-indented

Done.

http://codereview.appspot.com/6452064/diff/10017/src/views/mac/SkNSView.mm
File src/views/mac/SkNSView.mm (right):

http://codereview.appspot.com/6452064/diff/10017/src/views/mac/SkNSView.mm#ne...
src/views/mac/SkNSView.mm:158: { SK_MacEndKey,        kEnd_SkKey        },
On 2012/08/01 20:05:46, TomH wrote:
> nit: }-alignment brkoen

Done.

http://codereview.appspot.com/6452064/diff/10017/tests/WritePixelsTest.cpp
File tests/WritePixelsTest.cpp (right):

http://codereview.appspot.com/6452064/diff/10017/tests/WritePixelsTest.cpp#ne...
tests/WritePixelsTest.cpp:12: #include "SkDevice.h"
On 2012/08/01 20:05:46, TomH wrote:
> We needed to add new headers?

We were relying on SkGpuDevice.h to bring these in.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b