job topics

This creates a current job "topic" - commands for resizing the output (alt-0 through alt-3) and commands for controling execution (ctrl-D, ctrl-C, etc..) will apply to the current topic no matter what.

Arrow keys up and down move between jobs as topics and the command line. Return with a selected topic will enter the old command into the command line. Left arrow from a topic moves back to the command line.

commited: http://code.google.com/p/plush/source/detail?r=962b1dc10fb36f29b292d077bbd14c0ffec53291

[mzero, 2012-07-27 23:32:30]

review please

[mzero, 2012-07-27 23:35:58]

check it out

[Jasvir, 2012-07-30 06:55:14]

LGTM

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js
File static/js/jobs.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode77
static/js/jobs.js:77: var nextTopic = currentTopic;
Recommend not masking the function name with a variable here.

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode366
static/js/jobs.js:366: keydown: keydown,
extraneous comma

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js
File static/js/shell.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js#newcode249
static/js/shell.js:249: if (cmd !== '') {
Perhaps cmd.trim() !== ''

[mark2, 2012-07-30 12:51:24]

take two - minor fixes fixed

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js
File static/js/jobs.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode77
static/js/jobs.js:77: var nextTopic = currentTopic;
On 2012/07/30 06:55:14, Jasvir wrote:
> Recommend not masking the function name with a variable here.

Done.

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode366
static/js/jobs.js:366: keydown: keydown,
On 2012/07/30 06:55:14, Jasvir wrote:
> extraneous comma

Done.

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js
File static/js/shell.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js#newcode249
static/js/shell.js:249: if (cmd !== '') {
done, but had to move the commandline.val(''); above the if: when you enter a
line of just spaces, it feels better if it simple removed and the cursor returns
to the left edge.

[Jasvir, 2012-08-01 02:08:23]

LGTM