Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7521)

Issue 6450162: GOP2-4: add script for batch indenting Scheme files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by John Mandereau
Modified:
11 years, 8 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

GOP2-4: add script for batch indenting Scheme files Establish some coding styles in Emacs This uses directory variables to enforce some coding style features in C++, Scheme and Texinfo files in the source tree.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Amend comment in Scheme indentation script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A .dir-locals.el View 1 chunk +11 lines, -0 lines 0 comments Download
A scripts/auxiliar/fixscm.sh View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
John Mandereau
Note: these two new files (.dir-locals.el from David Kastrup and fixscm.sh from me) actually operate ...
11 years, 8 months ago (2012-08-20 10:00:44 UTC) #1
dak
http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh File scripts/auxiliar/fixscm.sh (right): http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh#newcode15 scripts/auxiliar/fixscm.sh:15: emacs -batch "$@" --eval "${elisp_expression}" Can you verify that ...
11 years, 8 months ago (2012-08-20 10:11:57 UTC) #2
dak
11 years, 8 months ago (2012-08-20 10:50:11 UTC) #3
John Mandereau <john.mandereau@gmail.com> writes:

> Il giorno lun, 20/08/2012 alle 10.11 +0000, dak@gnu.org ha scritto:
>> http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh
>> File scripts/auxiliar/fixscm.sh (right):
>> 
>>
http://codereview.appspot.com/6450162/diff/1/scripts/auxiliar/fixscm.sh#newco...
>> scripts/auxiliar/fixscm.sh:15: emacs -batch "$@" --eval
>> "${elisp_expression}"
>> Can you verify that emacs -batch indeed obeys directory-local variables?
>
>
>>   Otherwise the above info is quite off
>
> This info is off whether Emacs -batch obeys dir-local variables or not:
> from your comment on -devel the directory-local settings you propose
> (indent-tabs-mode in scheme-mode) is not used by this script.  I'm
> resending a patch.

Sigh.  I have _never_ been proposing indent-tabs-mode in scheme-mode,
and most certainly my patch proposal was _quite_ the opposite, with the
_opposite_ effect.

Please don't further spread that myth.

It is not my fault that the Emacs-written Lisp print form of
(indent-tabs-mode . nil) happens to be (indent-tabs-mode).

Yes, it looks like calling a function indent-tabs-mode in that _quoted_
alist.  Emacs has no such function or minor mode.  It only has the
imprudently named _variable_ indent-tabs-mode which is set to _nil_
(!!!!) when the form written out by _Emacs_ into the .dir-locals.el file
is later interpreted as an alist.  Emacs wrote that as a result of using
M-x add-dir-local-variable RET.

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b