Throwing IllegalArgumentException in ApacheHttpRequest if content used with GET

Created to fix http://code.google.com/p/google-http-java-client/issues/detail?id=122 : ClassCastException in ApacheHttpRequest.setContent.

[yanivi, 2012-08-20 13:04:29]

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java
(right):

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java:65:
Preconditions.checkArgument(!(request instanceof HttpGet),
"!(request instanceof HttpGet)" -> "request instanceof
HttpEntityEnclosingRequest"

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java:66:
"Apache HTTP client does not support GET requests with content.");
"...GET..." -> "...%s...", request.getRequestLine().getMethod()

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/test/j...
File
google-http-client/src/test/java/com/google/api/client/http/apache/ApacheHttpTransportTest.java
(right):

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/test/j...
google-http-client/src/test/java/com/google/api/client/http/apache/ApacheHttpTransportTest.java:57:
ApacheHttpRequest getRequest = transport.buildGetRequest("http://www.test.url");
test the other methods also, i.e. put, post, delete, patch, head

[rmistry, 2012-08-22 13:46:11]

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java
(right):

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java:65:
Preconditions.checkArgument(!(request instanceof HttpGet),
On 2012/08/20 13:04:29, yanivi wrote:
> "!(request instanceof HttpGet)" -> "request instanceof
> HttpEntityEnclosingRequest"

Done.

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpRequest.java:66:
"Apache HTTP client does not support GET requests with content.");
On 2012/08/20 13:04:29, yanivi wrote:
> "...GET..." -> "...%s...", request.getRequestLine().getMethod()

Done.

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/test/j...
File
google-http-client/src/test/java/com/google/api/client/http/apache/ApacheHttpTransportTest.java
(right):

http://codereview.appspot.com/6450137/diff/2001/google-http-client/src/test/j...
google-http-client/src/test/java/com/google/api/client/http/apache/ApacheHttpTransportTest.java:57:
ApacheHttpRequest getRequest = transport.buildGetRequest("http://www.test.url");
On 2012/08/20 13:04:29, yanivi wrote:
> test the other methods also, i.e. put, post, delete, patch, head

Done.

[yanivi, 2012-08-22 20:24:57]

LGTM