Issue 6450114: Issue 2728: count pairs of brackets

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6450114: Issue 2728: count pairs of brackets (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by dak

Modified:
11 years, 8 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issue 2728: count pairs of brackets What this actually does is exiting the parser at the end of the main file, then reentering it for finishing the init file. This delivers useful error messages in case that the main input is incomplete, and provides a reliable parsing boundary.

Patch Set 1 #

Patch Set 2 : Don't even clone. Just exit parser at EOF of main file, reenter for rest of init file. #

Patch Set 3 : Make independent from 2729 patch set #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
M	lily/lexer.ll	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/lily-parser.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	lily/parser.yy	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Graham Percival

LGTM, and wow it's amazing that such an improvement in usability can come from so ...

11 years, 8 months ago (2012-08-12 14:32:01 UTC) #1

dak

11 years, 8 months ago (2012-08-12 14:50:21 UTC) #2

On 2012/08/12 14:32:01, Graham Percival wrote:
> LGTM, and wow it's amazing that such an improvement in usability can come from
> so few lines of code!

It is probably even more amazing for how long people put up with the old
behavior.

Expand All Messages | Collapse All Messages