keyring support

Add support for keyring as a Storage option.

Fixes issue #21.

[Ali Afshar, 2012-07-31 18:07:27]

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
Is this a third party library?

[jcgregorio_google, 2012-07-31 18:10:16]

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
Yes.

On 2012/07/31 18:07:27, Ali Afshar wrote:
> Is this a third party library?

[jcgregorio_google, 2012-08-01 17:04:47]

ping?

[aiuto, 2012-08-01 19:37:19]

lgtm

[Ali Afshar, 2012-08-01 19:37:55]

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
Should it be added as a dependency in setup.py?

On 2012/07/31 18:10:17, jcgregorio_google wrote:
> Yes.
> 
> On 2012/07/31 18:07:27, Ali Afshar wrote:
> > Is this a third party library?
>

[jcgregorio_google, 2012-08-01 19:59:26]

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=eb268fb96be...

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
The reason not to put it in setup.py is that it would cause issues with App
Engine, which can only handle pure Python modules.

There's a note about that in the class doc that this is an optional module.


On 2012/08/01 19:37:55, Ali Afshar wrote:
> Should it be added as a dependency in setup.py?
> 
> On 2012/07/31 18:10:17, jcgregorio_google wrote:
> > Yes.
> > 
> > On 2012/07/31 18:07:27, Ali Afshar wrote:
> > > Is this a third party library?
> > 
>

[Ali Afshar, 2012-08-01 20:18:00]

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
On 2012/08/01 19:59:26, jcgregorio_google wrote:
> The reason not to put it in setup.py is that it would cause issues with App
> Engine, which can only handle pure Python modules.
> 

SGTM
> There's a note about that in the class doc that this is an optional module.
> 
> 
> On 2012/08/01 19:37:55, Ali Afshar wrote:
> > Should it be added as a dependency in setup.py?
> > 
> > On 2012/07/31 18:10:17, jcgregorio_google wrote:
> > > Yes.
> > > 
> > > On 2012/07/31 18:07:27, Ali Afshar wrote:
> > > > Is this a third party library?
> > > 
> > 
>

[Ali Afshar, 2012-08-01 20:18:00]

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
File oauth2client/keyring_storage.py (right):

http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
oauth2client/keyring_storage.py:22: import keyring
On 2012/08/01 19:59:26, jcgregorio_google wrote:
> The reason not to put it in setup.py is that it would cause issues with App
> Engine, which can only handle pure Python modules.
> 

SGTM
> There's a note about that in the class doc that this is an optional module.
> 
> 
> On 2012/08/01 19:37:55, Ali Afshar wrote:
> > Should it be added as a dependency in setup.py?
> > 
> > On 2012/07/31 18:10:17, jcgregorio_google wrote:
> > > Yes.
> > > 
> > > On 2012/07/31 18:07:27, Ali Afshar wrote:
> > > > Is this a third party library?
> > > 
> > 
>

[Ali Afshar, 2012-08-02 16:14:30]

tests/test_oauth2client_appengine.py is missing, should it be there?

On 2012/08/01 20:18:00, Ali Afshar wrote:
>
http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
> File oauth2client/keyring_storage.py (right):
> 
>
http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
> oauth2client/keyring_storage.py:22: import keyring
> On 2012/08/01 19:59:26, jcgregorio_google wrote:
> > The reason not to put it in setup.py is that it would cause issues with App
> > Engine, which can only handle pure Python modules.
> > 
> 
> SGTM
> > There's a note about that in the class doc that this is an optional module.
> > 
> > 
> > On 2012/08/01 19:37:55, Ali Afshar wrote:
> > > Should it be added as a dependency in setup.py?
> > > 
> > > On 2012/07/31 18:10:17, jcgregorio_google wrote:
> > > > Yes.
> > > > 
> > > > On 2012/07/31 18:07:27, Ali Afshar wrote:
> > > > > Is this a third party library?
> > > > 
> > > 
> >

[jcgregorio_google, 2012-08-02 16:23:01]

D'oh. Will send that in another CL.

  -joe

On 2012/08/02 16:14:30, Ali Afshar wrote:
> tests/test_oauth2client_appengine.py is missing, should it be there?
> 
> On 2012/08/01 20:18:00, Ali Afshar wrote:
> >
>
http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage.py
> > File oauth2client/keyring_storage.py (right):
> > 
> >
>
http://codereview.appspot.com/6450070/diff/3001/oauth2client/keyring_storage....
> > oauth2client/keyring_storage.py:22: import keyring
> > On 2012/08/01 19:59:26, jcgregorio_google wrote:
> > > The reason not to put it in setup.py is that it would cause issues with
App
> > > Engine, which can only handle pure Python modules.
> > > 
> > 
> > SGTM
> > > There's a note about that in the class doc that this is an optional
module.
> > > 
> > > 
> > > On 2012/08/01 19:37:55, Ali Afshar wrote:
> > > > Should it be added as a dependency in setup.py?
> > > > 
> > > > On 2012/07/31 18:10:17, jcgregorio_google wrote:
> > > > > Yes.
> > > > > 
> > > > > On 2012/07/31 18:07:27, Ali Afshar wrote:
> > > > > > Is this a third party library?
> > > > > 
> > > > 
> > >