specialize SkAutoTUnref for const Ts

[reed1, 2012-07-27 12:57:18]

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h
File include/core/SkRefCnt.h (right):

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:179: protected:
Do we need the = NULL for our protected constructor?

Do we want to make the default constructor private (and unimplemented) so no one
can accidentally make one of these, outside of our subclasses?

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:194: typedef typename SkAutoTUnrefBase<T>::template
BlockRef<T> BlockRefT;
LF

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:209: typedef typename SkAutoTUnrefBase<const
T>::template BlockRef<T> BlockRefT;
LF

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:210: const BlockRefT* operator->() const {
wow, we really need the SkAutoTUnrefBase<const T> qualifier on fObj?

[bsalomon, 2012-07-27 13:08:51]

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h
File include/core/SkRefCnt.h (right):

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:179: protected:
On 2012/07/27 12:57:18, reed1 wrote:
> Do we need the = NULL for our protected constructor?
> 
> Do we want to make the default constructor private (and unimplemented) so no
one
> can accidentally make one of these, outside of our subclasses?

Done.

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:194: typedef typename SkAutoTUnrefBase<T>::template
BlockRef<T> BlockRefT;
On 2012/07/27 12:57:18, reed1 wrote:
> LF

Done.

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:209: typedef typename SkAutoTUnrefBase<const
T>::template BlockRef<T> BlockRefT;
On 2012/07/27 12:57:18, reed1 wrote:
> LF

Done.

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newco...
include/core/SkRefCnt.h:210: const BlockRefT* operator->() const {
On 2012/07/27 12:57:18, reed1 wrote:
> wow, we really need the SkAutoTUnrefBase<const T> qualifier on fObj?

GCC on my Linux box wouldn't build without it. I dont' understand why.

../include/core/SkRefCnt.h: In member function ‘const typename
SkAutoTUnrefBase<const T>::BlockRef<T>* SkAutoTUnref<const T>::operator->()
const’:
../include/core/SkRefCnt.h:214: error: ‘fObj’ was not declared in this scope

[bsalomon, 2012-07-27 13:30:24]

Committed as 4802 on verbal LGTM from Mike.