Issue 6450054: specialize SkAutoTUnref for const Ts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6450054: specialize SkAutoTUnref for const Ts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 4 : Mike's comments #

Patch Set 5 : add LFs change parent scoping to this-> #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -11 lines)			Patch
	M	include/core/SkRefCnt.h	View	1 2 3 4	3 chunks	+42 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h File include/core/SkRefCnt.h (right): http://codereview.appspot.com/6450054/diff/1002/include/core/SkRefCnt.h#newcode179 include/core/SkRefCnt.h:179: protected: Do we need the = NULL for our ...

13 years ago (2012-07-27 12:57:18 UTC) #2

bsalomon

13 years ago (2012-07-27 13:08:51 UTC) #3

Committed as 4802 on verbal LGTM from Mike.

Expand All Messages | Collapse All Messages