Issue 6449125: If we do a "fast transform" and just map the src-bounds into dst-bounds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449125: If we do a "fast transform" and just map the src-bounds into dst-bounds

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by reed1

Modified:
12 years, 4 months ago

Reviewers:
bsalomon, robertphillips, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

If we do a "fast transform" and just map the src-bounds into dst-bounds (to avoid re-computing the bounds of the dst from scratch), we must also mimic ComputeBounds' handling of infinities: if the computed rect is non-finite, we must empty it and mark the dst path as non-finite. Fixes http://code.google.com/p/chromium/issues/detail?id=141651

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -6 lines)			Patch
	M	src/core/SkPath.cpp	View	1 2 3	2 chunks	+26 lines, -6 lines	1 comment	Download
	M	tests/PathTest.cpp	View	1 2 3 4	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM https://codereview.appspot.com/6449125/diff/1004/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.appspot.com/6449125/diff/1004/src/core/SkPath.cpp#newcode1818 src/core/SkPath.cpp:1818: Should there be a test here saying "if ...

12 years, 4 months ago (2012-08-10 10:50:00 UTC) #3

Landed as r5042.

Expand All Messages | Collapse All Messages