Issue 6449079: Added check for aa/bw rect merging

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6449079: Added check for aa/bw rect merging (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Don't know how zealous we want to be here but such cases occur when running the GMs in sample app.

Patch Set 1 #

Total comments: 5

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -28 lines)			Patch
	M	src/core/SkClipStack.cpp	View		5 chunks	+58 lines, -26 lines	5 comments	Download
	M	tests/ClipStackTest.cpp	View		4 chunks	+124 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

robertphillips

http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp#newcode98 src/core/SkClipStack.cpp:98: return fSaveCount == saveCount && Very surprised this wasn't ...

11 years, 11 months ago (2012-08-01 20:37:33 UTC) #1

bsalomon

LGTM http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp#newcode98 src/core/SkClipStack.cpp:98: return fSaveCount == saveCount && On 2012/08/01 20:37:34, ...

11 years, 11 months ago (2012-08-01 21:17:44 UTC) #3

reed1

lgtm http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp#newcode91 src/core/SkClipStack.cpp:91: */ rename to canBeIntersectedInPlace(...) ?

11 years, 11 months ago (2012-08-01 21:18:03 UTC) #4

robertphillips

11 years, 11 months ago (2012-08-02 12:49:22 UTC) #5

committed as r4907

http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp
File src/core/SkClipStack.cpp (right):

http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp#newcode91
src/core/SkClipStack.cpp:91: */
On 2012/08/01 21:18:03, reed1 wrote:
> rename to canBeIntersectedInPlace(...) ?

Done.

http://codereview.appspot.com/6449079/diff/1/src/core/SkClipStack.cpp#newcode98
src/core/SkClipStack.cpp:98: return  fSaveCount == saveCount &&
On 2012/08/01 21:17:44, bsalomon wrote:
> On 2012/08/01 20:37:34, robertphillips wrote:
> > Very surprised this wasn't in here before
> 
> Could it be simplified to:
> (SkRegion::kIntersect_Op == op && (SkRegion::kIntersect_Op == fOp ||
> SkRegion::kReplace_Op == fOp))
> ?

Done.

Expand All Messages | Collapse All Messages