Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5683)

Issue 6449070: Replace GrClip with SkClipStack (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL removes all use of GrClip. A follow on CL will actually remove GrClip & its related classes.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -198 lines) Patch
M include/core/SkClipStack.h View 2 chunks +3 lines, -1 line 0 comments Download
M include/gpu/GrClip.h View 2 chunks +6 lines, -4 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrClip.cpp View 2 chunks +8 lines, -26 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 9 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 11 chunks +22 lines, -23 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 2 chunks +42 lines, -34 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 2 chunks +9 lines, -18 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 8 chunks +26 lines, -51 lines 2 comments Download
M tests/ClipCacheTest.cpp View 5 chunks +8 lines, -24 lines 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 4 months ago (2012-07-31 17:43:47 UTC) #1
bsalomon
LGTM http://codereview.appspot.com/6449070/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): http://codereview.appspot.com/6449070/diff/1/src/gpu/SkGpuDevice.cpp#newcode352 src/gpu/SkGpuDevice.cpp:352: fClipData.fClipStack = canvas->getClipStack(); Do we have a clipstack ...
12 years, 4 months ago (2012-07-31 17:55:21 UTC) #2
robertphillips
12 years, 4 months ago (2012-07-31 19:16:27 UTC) #3
committed as r4865

http://codereview.appspot.com/6449070/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6449070/diff/1/src/gpu/SkGpuDevice.cpp#newcode352
src/gpu/SkGpuDevice.cpp:352: fClipData.fClipStack = canvas->getClipStack();
I don't think so since 'onDetachFromCanvas' should be called when SkCanvas goes
away. I suppose there could be problems if one directly called rendering methods
on the SkGpuDevice with no SkCanvas attached but I don't think that is a use
case we are considering?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b