Issue 6448105: remove need to set plush_datadir during development

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6448105: remove need to set plush_datadir during development (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mzero

Modified:
13 years, 1 month ago

Reviewers:
Jasvir, thecomfyshell

Visibility:
Public.

More Reviews

Description

this means that you can just run dist/build/plush/plush -w right after build. perhaps this should only be on for developer builds... any thoughts? commited: http://code.google.com/p/plush/source/detail?r=56cc160186679951a16096711eb3ab72484d5820

Patch Set 1 #

Patch Set 2 : add a Production flag #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -2 lines)			Patch
M	plush.cabal	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/Plush/Run.hs	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/Plush/Server.hs	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/Plush/Utilities.hs	View	1	2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mzero

updated to make this behavior only available for development builds added a Production flag that ...

13 years, 2 months ago (2012-08-02 21:07:13 UTC) #2

LGTM

Expand All Messages | Collapse All Messages