Issue 6448098: Default to null=True for Django Fields. Fixes issue #167.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6448098: Default to null=True for Django Fields. Fixes issue #167. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by jcgregorio_google

Modified:
12 years, 12 months ago

Reviewers:
rmistry, Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 12 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	oauth2client/django_orm.py	View		2 chunks	+10 lines, -0 lines	0 comments	Download
	M	samples/django_sample/settings.py	View		2 chunks	+8 lines, -9 lines	3 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jcgregorio_google

On 2012/08/01 18:18:12, jcgregorio_google wrote: This is the bug: http://code.google.com/p/google-api-python-client/issues/detail?id=161

12 years, 12 months ago (2012-08-01 18:19:47 UTC) #2

Ali Afshar

LGTM http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py File samples/django_sample/settings.py (right): http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py#newcode13 samples/django_sample/settings.py:13: DATABASES = { How do the changes in ...

12 years, 12 months ago (2012-08-01 20:35:31 UTC) #4

jcgregorio_google

http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py File samples/django_sample/settings.py (right): http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py#newcode13 samples/django_sample/settings.py:13: DATABASES = { On 2012/08/01 20:35:31, Ali Afshar wrote: ...

12 years, 12 months ago (2012-08-01 20:54:20 UTC) #5

Ali Afshar

12 years, 12 months ago (2012-08-01 20:56:48 UTC) #6

http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py
File samples/django_sample/settings.py (right):

http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.p...
samples/django_sample/settings.py:13: DATABASES = {
On 2012/08/01 20:54:20, jcgregorio_google wrote:
> On 2012/08/01 20:35:31, Ali Afshar wrote:
> > How do the changes in this file affect the goal of the CL?
> 
> They make the sample work under Django 1.4, which is apparently where the
issue
> exists.

LGTM

Expand All Messages | Collapse All Messages