Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 6448098: Default to null=True for Django Fields. Fixes issue #167. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by jcgregorio_google
Modified:
12 years, 11 months ago
Reviewers:
rmistry, Ali Afshar
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M oauth2client/django_orm.py View 2 chunks +10 lines, -0 lines 0 comments Download
M samples/django_sample/settings.py View 2 chunks +8 lines, -9 lines 3 comments Download

Messages

Total messages: 6
jcgregorio_google
12 years, 11 months ago (2012-08-01 18:18:12 UTC) #1
jcgregorio_google
On 2012/08/01 18:18:12, jcgregorio_google wrote: This is the bug: http://code.google.com/p/google-api-python-client/issues/detail?id=161
12 years, 11 months ago (2012-08-01 18:19:47 UTC) #2
rmistry
LGTM
12 years, 11 months ago (2012-08-01 18:21:14 UTC) #3
Ali Afshar
LGTM http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py File samples/django_sample/settings.py (right): http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py#newcode13 samples/django_sample/settings.py:13: DATABASES = { How do the changes in ...
12 years, 11 months ago (2012-08-01 20:35:31 UTC) #4
jcgregorio_google
http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py File samples/django_sample/settings.py (right): http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py#newcode13 samples/django_sample/settings.py:13: DATABASES = { On 2012/08/01 20:35:31, Ali Afshar wrote: ...
12 years, 11 months ago (2012-08-01 20:54:20 UTC) #5
Ali Afshar
12 years, 11 months ago (2012-08-01 20:56:48 UTC) #6
http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.py
File samples/django_sample/settings.py (right):

http://codereview.appspot.com/6448098/diff/1/samples/django_sample/settings.p...
samples/django_sample/settings.py:13: DATABASES = {
On 2012/08/01 20:54:20, jcgregorio_google wrote:
> On 2012/08/01 20:35:31, Ali Afshar wrote:
> > How do the changes in this file affect the goal of the CL?
> 
> They make the sample work under Django 1.4, which is apparently where the
issue
> exists.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b