Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2346)

Issue 6448080: Make 0-texture GrCustomEffects work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bsalomon
Modified:
12 years, 3 months ago
Reviewers:
rileya, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : remove redundant "maximum" in comment #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M src/gpu/GrContext.cpp View 2 chunks +8 lines, -8 lines 3 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 chunks +14 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.h View 1 chunk +0 lines, -6 lines 1 comment Download
M src/gpu/gl/GrGLUniformManager.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3
bsalomon
I couldn't push the changes as deep as I hoped. My next CL will allow ...
12 years, 3 months ago (2012-07-30 19:29:10 UTC) #1
TomH
LGTM http://codereview.appspot.com/6448080/diff/4001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): http://codereview.appspot.com/6448080/diff/4001/src/gpu/GrContext.cpp#newcode1033 src/gpu/GrContext.cpp:1033: // TODO: strokeWidth can't be larger than zero ...
12 years, 3 months ago (2012-07-31 15:13:56 UTC) #2
bsalomon
12 years, 3 months ago (2012-07-31 17:56:07 UTC) #3
Closed with r4858.

http://codereview.appspot.com/6448080/diff/4001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6448080/diff/4001/src/gpu/GrContext.cpp#newcode...
src/gpu/GrContext.cpp:1049: DrawCategory category = (DEFER_PATHS) ?
kBuffered_DrawCategory :
On 2012/07/30 19:29:10, bsalomon wrote:
> This part is somewhat orthogonal to the rest of the change. However, the fact
> that the AutoStageDisable was inserted before the early-out to
internalDrawPath
> gave problems when I was inserting a dummy stage on every draw to test
0-texture
> stages.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b