Remove uniform names from top of GrGLProgram.cpp, manager responsible for "u" and stage num tags

[bsalomon, 2012-07-25 20:15:44]

Follow up to addition of the uniform manager. I put three names on CC line in
hopes someone will step up to the Reviewers line. :)

[Stephen White, 2012-07-25 20:29:44]

On 2012/07/25 20:15:44, bsalomon wrote:
> Follow up to addition of the uniform manager. I put three names on CC line in
> hopes someone will step up to the Reviewers line. :)

I'll take a look.

[Stephen White, 2012-07-25 20:36:59]

LGTM.  I like it!  (Assuming the tests do too, of course).

Change below is optional.

http://codereview.appspot.com/6448049/diff/14/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

http://codereview.appspot.com/6448049/diff/14/src/gpu/gl/GrGLProgram.cpp#newc...
src/gpu/gl/GrGLProgram.cpp:827: builder.setNonStage();
I guess a slightly safer (if redundant) way of doing this would be to call
setNonStage() at the end of genStageCode().  Then you wouldn't need to remember
to do it at the end of each loop.

[bsalomon, 2012-07-25 21:04:31]

Thanks, Stephen! I like the suggestion and took it. Committed as r4770.

On 2012/07/25 20:36:59, Stephen White wrote:
> LGTM.  I like it!  (Assuming the tests do too, of course).
> 
> Change below is optional.
> 
> http://codereview.appspot.com/6448049/diff/14/src/gpu/gl/GrGLProgram.cpp
> File src/gpu/gl/GrGLProgram.cpp (right):
> 
>
http://codereview.appspot.com/6448049/diff/14/src/gpu/gl/GrGLProgram.cpp#newc...
> src/gpu/gl/GrGLProgram.cpp:827: builder.setNonStage();
> I guess a slightly safer (if redundant) way of doing this would be to call
> setNonStage() at the end of genStageCode().  Then you wouldn't need to
remember
> to do it at the end of each loop.